Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/JsEngine.h

Issue 29499617: Noissue - set default values for platform interfaces to nullptr (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: Created July 27, 2017, 10:16 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/JsEngine.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/AdblockPlus/JsEngine.h
diff --git a/include/AdblockPlus/JsEngine.h b/include/AdblockPlus/JsEngine.h
index 7ff04d45bfdf0c0326d65f0d837286575cc9a7aa..f39dfc87035bf3e82d0f51225cfca7d4e46494d2 100644
--- a/include/AdblockPlus/JsEngine.h
+++ b/include/AdblockPlus/JsEngine.h
@@ -127,6 +127,10 @@ namespace AdblockPlus
/**
* Creates a new JavaScript engine instance.
+ *
+ * When a parameter value is nullptr the corresponding default
+ * implementation is chosen.
+ *
* @param appInfo Information about the app.
* @param timer Implementation of timer.
* @param fileSystem Implementation of filesystem.
@@ -135,10 +139,8 @@ namespace AdblockPlus
* @return New `JsEngine` instance.
*/
static JsEnginePtr New(const AppInfo& appInfo = AppInfo(),
- TimerPtr timer = CreateDefaultTimer(),
- FileSystemPtr fileSystem = CreateDefaultFileSystem(),
- WebRequestPtr webRequest = CreateDefaultWebRequest(),
- LogSystemPtr logSystem = CreateDefaultLogSystem());
+ TimerPtr timer = nullptr, FileSystemPtr fileSystem = nullptr,
+ WebRequestPtr webRequest = nullptr, LogSystemPtr logSystem = nullptr);
/**
* Registers the callback function for an event.
« no previous file with comments | « no previous file | src/JsEngine.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld