Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29499617: Noissue - set default values for platform interfaces to nullptr (Closed)

Created:
July 27, 2017, 10:16 a.m. by sergei
Modified:
July 27, 2017, 2:59 p.m.
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

It prevents not only from dereferencing of nullptr but also allows to have parameters for factory methods. Review: https://codereview.adblockplus.org/29499617/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M include/AdblockPlus/JsEngine.h View 2 chunks +6 lines, -4 lines 0 comments Download
M src/JsEngine.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2
sergei
July 27, 2017, 10:17 a.m. (2017-07-27 10:17:45 UTC) #1
hub
July 27, 2017, 1:21 p.m. (2017-07-27 13:21:59 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld