Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: src/DefaultWebRequest.cpp

Issue 29499621: Issue 4983 - Get rid of Sleep() in the WebRequest test (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: Created July 27, 2017, 10:18 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/DefaultWebRequest.h ('k') | src/JsEngine.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 #include "DefaultWebRequest.h" 18 #include "DefaultWebRequest.h"
19 #include <thread> 19 #include <thread>
20 20
21 using namespace AdblockPlus; 21 using namespace AdblockPlus;
22 22
23 DefaultWebRequest::DefaultWebRequest(std::unique_ptr<DefaultWebRequestSync>&& sy ncImpl) 23 DefaultWebRequest::DefaultWebRequest(const Scheduler& scheduler, std::unique_ptr <DefaultWebRequestSync>&& syncImpl)
24 : syncImpl(std::move(syncImpl)) 24 : scheduler(scheduler), syncImpl(std::move(syncImpl))
25 { 25 {
26 26
27 } 27 }
28 28
29 DefaultWebRequest::~DefaultWebRequest() 29 DefaultWebRequest::~DefaultWebRequest()
30 { 30 {
31 31
32 } 32 }
33 33
34 void DefaultWebRequest::GET(const std::string& url, const HeaderList& requestHea ders, const GetCallback& getCallback) 34 void DefaultWebRequest::GET(const std::string& url, const HeaderList& requestHea ders, const GetCallback& getCallback)
35 { 35 {
36 std::thread([this, url, requestHeaders, getCallback] 36 scheduler([this, url, requestHeaders, getCallback]
37 { 37 {
38 getCallback(this->syncImpl->GET(url, requestHeaders)); 38 getCallback(this->syncImpl->GET(url, requestHeaders));
39 }).detach(); 39 });
40 } 40 }
OLDNEW
« no previous file with comments | « src/DefaultWebRequest.h ('k') | src/JsEngine.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld