Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29499621: Issue 4983 - Get rid of Sleep() in the WebRequest test (Closed)

Created:
July 27, 2017, 10:18 a.m. by sergei
Modified:
July 28, 2017, 6:43 a.m.
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

# depends on https://codereview.adblockplus.org/29499617/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -44 lines) Patch
M include/AdblockPlus/JsEngine.h View 2 chunks +2 lines, -1 line 0 comments Download
A + include/AdblockPlus/Scheduler.h View 1 chunk +12 lines, -19 lines 0 comments Download
M libadblockplus.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M src/DefaultWebRequest.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/DefaultWebRequest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/JsEngine.cpp View 3 chunks +8 lines, -3 lines 0 comments Download
M test/WebRequest.cpp View 4 chunks +25 lines, -16 lines 0 comments Download

Messages

Total messages: 2
sergei
July 27, 2017, 10:20 a.m. (2017-07-27 10:20:59 UTC) #1
hub
July 27, 2017, 3:44 p.m. (2017-07-27 15:44:22 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld