Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29499630: Issue 4938 - fix race conditions and get rid of hacks related to DefaultFileSystem (Closed)

Created:
July 27, 2017, 11:15 a.m. by sergei
Modified:
July 28, 2017, 6:44 a.m.
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

# depends on https://codereview.adblockplus.org/29499621/ # Basically this codereview is the last one removing usage of detached threads in tests.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -123 lines) Patch
M include/AdblockPlus/JsEngine.h View 1 chunk +1 line, -1 line 0 comments Download
M src/DefaultFileSystem.h View 3 chunks +3 lines, -1 line 0 comments Download
M src/DefaultFileSystem.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M src/JsEngine.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M test/DefaultFileSystem.cpp View 1 chunk +125 lines, -68 lines 0 comments Download
M test/FilterEngine.cpp View 5 chunks +55 lines, -38 lines 0 comments Download

Messages

Total messages: 2
sergei
July 27, 2017, 11:18 a.m. (2017-07-27 11:18:29 UTC) #1
hub
July 27, 2017, 3:50 p.m. (2017-07-27 15:50:03 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld