Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29499699: Noissue - make line_type in parser.py private and fix its docstring (Closed)

Created:
July 27, 2017, 1:19 p.m. by Vasily Kuznetsov
Modified:
July 27, 2017, 7 p.m.
Reviewers:
mathias
Visibility:
Public.

Description

Noissue - make line_type in parser.py private and fix its docstring

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M abp/filters/parser.py View 2 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 3
Vasily Kuznetsov
line_type class factory function is internal to parser.py and should not be used outside of ...
July 27, 2017, 1:22 p.m. (2017-07-27 13:22:27 UTC) #1
mathias
LGTM.
July 27, 2017, 1:29 p.m. (2017-07-27 13:29:27 UTC) #2
Vasily Kuznetsov
July 27, 2017, 7 p.m. (2017-07-27 19:00:44 UTC) #3

Powered by Google App Engine
This is Rietveld