Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29500562: Issue 5389 - Create basic circle ci build script (Closed)

Created:
July 28, 2017, 10:02 a.m. by jens
Modified:
Aug. 8, 2017, 2:06 p.m.
Reviewers:
diegocarloslima, anton
CC:
Felix Dahlke, René Jeschke
Visibility:
Public.

Description

Issue 5389 - Create basic circle ci build script

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
A .circleci/config.yml View 1 chunk +34 lines, -0 lines 2 comments Download

Messages

Total messages: 4
diegocarloslima
https://codereview.adblockplus.org/29500562/diff/29500563/.circleci/config.yml File .circleci/config.yml (right): https://codereview.adblockplus.org/29500562/diff/29500563/.circleci/config.yml#newcode34 .circleci/config.yml:34: destination: apks/ Looks good, but where some needed variables ...
Aug. 7, 2017, 9:25 p.m. (2017-08-07 21:25:21 UTC) #1
jens
https://codereview.adblockplus.org/29500562/diff/29500563/.circleci/config.yml File .circleci/config.yml (right): https://codereview.adblockplus.org/29500562/diff/29500563/.circleci/config.yml#newcode34 .circleci/config.yml:34: destination: apks/ On 2017/08/07 21:25:21, diegocarloslima wrote: > Looks ...
Aug. 8, 2017, 10:36 a.m. (2017-08-08 10:36:50 UTC) #2
diegocarloslima
On 2017/08/08 10:36:50, jens wrote: > https://codereview.adblockplus.org/29500562/diff/29500563/.circleci/config.yml > File .circleci/config.yml (right): > > https://codereview.adblockplus.org/29500562/diff/29500563/.circleci/config.yml#newcode34 > ...
Aug. 8, 2017, 1:31 p.m. (2017-08-08 13:31:17 UTC) #3
anton
Aug. 8, 2017, 1:32 p.m. (2017-08-08 13:32:14 UTC) #4
On 2017/08/08 13:31:17, diegocarloslima wrote:
> On 2017/08/08 10:36:50, jens wrote:
> >
https://codereview.adblockplus.org/29500562/diff/29500563/.circleci/config.yml
> > File .circleci/config.yml (right):
> > 
> >
>
https://codereview.adblockplus.org/29500562/diff/29500563/.circleci/config.ym...
> > .circleci/config.yml:34: destination: apks/
> > On 2017/08/07 21:25:21, diegocarloslima wrote:
> > > Looks good, but where some needed variables such as the Android SDK goes?
> I'm
> > > not familiar with circle CI btw :)
> > 
> > CircleCi provides docker images for Android builds. All the Android specific
> > stuff in bundled in the docker image and is automatically installed.
Depending
> > on what version we use, we have a different Emulator, SDK, SDK-Tool and
Build
> > Tool versions. The docker images are open-source and available on GitHub:
> > https://github.com/circleci/circleci-images/tree/master/android
> > 
> > Basically I used the recommended Android build script with some litte
> > extensions, such as storing the APKs and the lint reports.
> > CircleCI offers a lot more options and customizations. For example we can
> think
> > about automatically include translations in the future. And of course we
> should
> > write some tests and include running them in the build.
> 
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld