Issue 5389 - Create basic circle ci build script

Issue 5389 - Create basic circle ci build script

[diegocarloslima, 2017-08-07 21:25:21]

https://codereview.adblockplus.org/29500562/diff/29500563/.circleci/config.yml
File .circleci/config.yml (right):

https://codereview.adblockplus.org/29500562/diff/29500563/.circleci/config.ym...
.circleci/config.yml:34: destination: apks/
Looks good, but where some needed variables such as the Android SDK goes? I'm
not familiar with circle CI btw :)

[jens, 2017-08-08 10:36:50]

https://codereview.adblockplus.org/29500562/diff/29500563/.circleci/config.yml
File .circleci/config.yml (right):

https://codereview.adblockplus.org/29500562/diff/29500563/.circleci/config.ym...
.circleci/config.yml:34: destination: apks/
On 2017/08/07 21:25:21, diegocarloslima wrote:
> Looks good, but where some needed variables such as the Android SDK goes? I'm
> not familiar with circle CI btw :)

CircleCi provides docker images for Android builds. All the Android specific
stuff in bundled in the docker image and is automatically installed. Depending
on what version we use, we have a different Emulator, SDK, SDK-Tool and Build
Tool versions. The docker images are open-source and available on GitHub:
https://github.com/circleci/circleci-images/tree/master/android

Basically I used the recommended Android build script with some litte
extensions, such as storing the APKs and the lint reports.
CircleCI offers a lot more options and customizations. For example we can think
about automatically include translations in the future. And of course we should
write some tests and include running them in the build.

[diegocarloslima, 2017-08-08 13:31:17]

On 2017/08/08 10:36:50, jens wrote:
> https://codereview.adblockplus.org/29500562/diff/29500563/.circleci/config.yml
> File .circleci/config.yml (right):
> 
>
https://codereview.adblockplus.org/29500562/diff/29500563/.circleci/config.ym...
> .circleci/config.yml:34: destination: apks/
> On 2017/08/07 21:25:21, diegocarloslima wrote:
> > Looks good, but where some needed variables such as the Android SDK goes?
I'm
> > not familiar with circle CI btw :)
> 
> CircleCi provides docker images for Android builds. All the Android specific
> stuff in bundled in the docker image and is automatically installed. Depending
> on what version we use, we have a different Emulator, SDK, SDK-Tool and Build
> Tool versions. The docker images are open-source and available on GitHub:
> https://github.com/circleci/circleci-images/tree/master/android
> 
> Basically I used the recommended Android build script with some litte
> extensions, such as storing the APKs and the lint reports.
> CircleCI offers a lot more options and customizations. For example we can
think
> about automatically include translations in the future. And of course we
should
> write some tests and include running them in the build.

LGTM

[anton, 2017-08-08 13:32:14]

On 2017/08/08 13:31:17, diegocarloslima wrote:
> On 2017/08/08 10:36:50, jens wrote:
> >
https://codereview.adblockplus.org/29500562/diff/29500563/.circleci/config.yml
> > File .circleci/config.yml (right):
> > 
> >
>
https://codereview.adblockplus.org/29500562/diff/29500563/.circleci/config.ym...
> > .circleci/config.yml:34: destination: apks/
> > On 2017/08/07 21:25:21, diegocarloslima wrote:
> > > Looks good, but where some needed variables such as the Android SDK goes?
> I'm
> > > not familiar with circle CI btw :)
> > 
> > CircleCi provides docker images for Android builds. All the Android specific
> > stuff in bundled in the docker image and is automatically installed.
Depending
> > on what version we use, we have a different Emulator, SDK, SDK-Tool and
Build
> > Tool versions. The docker images are open-source and available on GitHub:
> > https://github.com/circleci/circleci-images/tree/master/android
> > 
> > Basically I used the recommended Android build script with some litte
> > extensions, such as storing the APKs and the lint reports.
> > CircleCI offers a lot more options and customizations. For example we can
> think
> > about automatically include translations in the future. And of course we
> should
> > write some tests and include running them in the build.
> 
> LGTM

LGTM