Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29501555: Issue 2373 - Add/change a sentence on filters page regarding EHH removing tag names by default (Closed)

Created:
July 31, 2017, 10:47 a.m. by ire
Modified:
Aug. 2, 2017, 4:31 p.m.
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Issue 2373 - Add/change a sentence on filters page regarding EHH removing tag names by default

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove "only" in s85 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M pages/filters.html View 1 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4
ire
July 31, 2017, 10:48 a.m. (2017-07-31 10:48:01 UTC) #1
Wladimir Palant
Looks good, only one nit. https://codereview.adblockplus.org/29501555/diff/29501556/pages/filters.html File pages/filters.html (right): https://codereview.adblockplus.org/29501555/diff/29501556/pages/filters.html#newcode210 pages/filters.html:210: <p>{{s85 The first advertisement ...
Aug. 1, 2017, 1:49 p.m. (2017-08-01 13:49:36 UTC) #2
ire
https://codereview.adblockplus.org/29501555/diff/29501556/pages/filters.html File pages/filters.html (right): https://codereview.adblockplus.org/29501555/diff/29501556/pages/filters.html#newcode210 pages/filters.html:210: <p>{{s85 The first advertisement above is contained inside an ...
Aug. 2, 2017, 9:56 a.m. (2017-08-02 09:56:01 UTC) #3
Wladimir Palant
Aug. 2, 2017, 10:02 a.m. (2017-08-02 10:02:42 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld