Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Unified Diff: tests/abp-53.png
Issue
29501558
:
Issue 5383 - Add tests for the Chrome and Firefox packagers (Closed)
Patch Set: Simplifying parameters
Created Sept. 21, 2017, 11:27 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.gitignore
README.md
packagerChrome.py
tests/README.md
tests/__init__.py
tests/abp-16.png
tests/abp-19.png
tests/abp-53.png
tests/chrome_rsa.pem
tests/conftest.py
tests/expecteddata/AppxManifest_edge_False_1337.xml
tests/expecteddata/AppxManifest_edge_True_None.xml
tests/expecteddata/manifest_chrome_build_1337.json
tests/expecteddata/manifest_chrome_devenv_None.json
tests/expecteddata/manifest_chrome_release_None.json
tests/expecteddata/manifest_edge_False_1337.json
tests/expecteddata/manifest_edge_True_None.json
tests/expecteddata/manifest_gecko-webext_build_1337.json
tests/expecteddata/manifest_gecko-webext_devenv_None.json
tests/expecteddata/manifest_gecko-webext_release_None.json
tests/metadata.chrome
tests/metadata.edge
tests/metadata.gecko-webext
tests/test_packagerEdge.py
tests/test_packagerWebExt.py
tests/tools.py
tox.ini
View side-by-side diff with in-line comments
Download patch
« packagerChrome.py
('K') |
« tests/abp-19.png
('k') |
tests/chrome_rsa.pem »
('j') |
tests/test_packagerEdge.py »
('J')
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
« packagerChrome.py
('K') |
« tests/abp-19.png
('k') |
tests/chrome_rsa.pem »
('j') |
tests/test_packagerEdge.py »
('J')
Edit Message
Issue 29501558: Issue 5383 - Add tests for the Chrome and Firefox packagers (Closed)
Created July 31, 2017, 12:07 p.m. by tlucas
Modified Oct. 22, 2017, 11:33 a.m.
Reviewers: Vasily Kuznetsov, Sebastian Noack, kzar
Base URL:
Comments: 264
This is Rietveld