Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29501568: Issue 3673 - Use separate function to chain promises (Closed)

Created:
July 31, 2017, 12:28 p.m. by Manish Jethani
Modified:
Aug. 1, 2017, 7:02 a.m.
Reviewers:
kzar
CC:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/abp2blocklist
Visibility:
Public.

Description

Issue 3673 - Use separate function to chain promises JSHydra translates let to var, therefore we must create a closure so every iteration over the callee list has its own value of index, which is lazily passed to the map function.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M lib/abp2blocklist.js View 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 3
Manish Jethani
July 31, 2017, 12:28 p.m. (2017-07-31 12:28:51 UTC) #1
Manish Jethani
Patch Set 1 JSHydra translates let to var, therefore we must create a closure so ...
July 31, 2017, 12:31 p.m. (2017-07-31 12:31:08 UTC) #2
kzar
July 31, 2017, 2:32 p.m. (2017-07-31 14:32:01 UTC) #3
LGTM, go ahead and push this.

Powered by Google App Engine
This is Rietveld