Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29501574: Noissue - Fix a constructor order warning (Closed)

Created:
July 31, 2017, 12:38 p.m. by hub
Modified:
July 31, 2017, 12:51 p.m.
Reviewers:
sergei
Base URL:
https://hg.adblockplus.org/libadblockplus/
Visibility:
Public.

Description

Noissue - Fix a constructor order warning https://codereview.adblockplus.org/29501574

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/JsEngine.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
hub
July 31, 2017, 12:38 p.m. (2017-07-31 12:38:04 UTC) #1
sergei
LGTM
July 31, 2017, 12:38 p.m. (2017-07-31 12:38:53 UTC) #2
hub
Didn't get the warning on macOS. I get it on Fedora Linux.
July 31, 2017, 12:39 p.m. (2017-07-31 12:39:02 UTC) #3
sergei
I'm not on windows, it's not shown there but I know it and have seen ...
July 31, 2017, 12:40 p.m. (2017-07-31 12:40:59 UTC) #4
sergei
July 31, 2017, 12:49 p.m. (2017-07-31 12:49:03 UTC) #5
On 2017/07/31 12:40:59, sergei wrote:
> I'm not on windows, it's not shown there but I know it and have seen it on
> linux. It's actually fixed in https://codereview.adblockplus.org/29500602/

I'm on windows*

Powered by Google App Engine
This is Rietveld