Issue 29503619: Noissue - Throw TypeError when RTCPeerConnection called without new operator

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29503619: Noissue - Throw TypeError when RTCPeerConnection called without new operator (Closed)

Created:
Aug. 2, 2017, 4:58 p.m. by kzar

Modified:
Aug. 3, 2017, 4:17 p.m.

Reviewers:
Manish Jethani

CC:
Sebastian Noack

Visibility:
Public.

Description

Noissue - Throw TypeError when RTCPeerConnection called without new operator

Patch Set 1 #

Created: Aug. 2, 2017, 4:58 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	inject.preload.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

kzar

Patch Set 1 Whilst investigating #5382 I noticed this mistake. Instead of throwing TypeError when ...

Aug. 2, 2017, 5:01 p.m. (2017-08-02 17:01:26 UTC) #1

Manish Jethani

Aug. 3, 2017, 9:51 a.m. (2017-08-03 09:51:25 UTC) #2

On 2017/08/02 17:01:26, kzar wrote:
> Patch Set 1
> 
> Whilst investigating #5382 I noticed this mistake. Instead of throwing
TypeError
> when the RTCPeerConnection constructor was called without using the 'new'
> operator, we were accidentally recursing until the stack was blown. (For an
> example of how it should work see the wrapped WebSocket constructor earlier in
> the code.)

LGTM

Expand All Messages | Collapse All Messages