Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29505606: Issue 5360 - Whitelist subscription shown as '-user-35236' (Closed)

Created:
Aug. 4, 2017, 6:57 p.m. by diegocarloslima
Modified:
Aug. 8, 2017, 12:02 p.m.
Reviewers:
anton, jens
CC:
Felix Dahlke, René Jeschke
Visibility:
Public.

Description

Issue 5360 - User added whitelist shown as '-user-35236' and not the URL name

Patch Set 1 #

Total comments: 5

Patch Set 2 : Adjustments in code style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M mobile/android/thirdparty/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java View 1 4 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 5
diegocarloslima
Aug. 4, 2017, 7:10 p.m. (2017-08-04 19:10:42 UTC) #1
anton
https://codereview.adblockplus.org/29505606/diff/29505607/mobile/android/thirdparty/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java File mobile/android/thirdparty/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java (right): https://codereview.adblockplus.org/29505606/diff/29505607/mobile/android/thirdparty/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java#newcode284 mobile/android/thirdparty/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java:284: ActiveSubscriptionContainer(Context context) { `{` should be in the next ...
Aug. 7, 2017, 9:40 a.m. (2017-08-07 09:40:16 UTC) #2
diegocarloslima
https://codereview.adblockplus.org/29505606/diff/29505607/mobile/android/thirdparty/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java File mobile/android/thirdparty/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java (right): https://codereview.adblockplus.org/29505606/diff/29505607/mobile/android/thirdparty/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java#newcode284 mobile/android/thirdparty/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java:284: ActiveSubscriptionContainer(Context context) { On 2017/08/07 09:40:16, anton wrote: > ...
Aug. 7, 2017, 11:07 a.m. (2017-08-07 11:07:34 UTC) #3
anton
On 2017/08/07 11:07:34, diegocarloslima wrote: > https://codereview.adblockplus.org/29505606/diff/29505607/mobile/android/thirdparty/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java > File > mobile/android/thirdparty/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java > (right): > > ...
Aug. 8, 2017, 5:34 a.m. (2017-08-08 05:34:16 UTC) #4
jens
Aug. 8, 2017, 7:48 a.m. (2017-08-08 07:48:58 UTC) #5 
On 2017/08/08 05:34:16, anton wrote:
> On 2017/08/07 11:07:34, diegocarloslima wrote:
> >
>
https://codereview.adblockplus.org/29505606/diff/29505607/mobile/android/thir...
> > File
> >
>
mobile/android/thirdparty/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java
> > (right):
> > 
> >
>
https://codereview.adblockplus.org/29505606/diff/29505607/mobile/android/thir...
> >
>
mobile/android/thirdparty/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java:284:
> > ActiveSubscriptionContainer(Context context) {
> > On 2017/08/07 09:40:16, anton wrote:
> > > `{` should be in the next line
> > 
> > Acknowledged.
> > 
> >
>
https://codereview.adblockplus.org/29505606/diff/29505607/mobile/android/thir...
> >
>
mobile/android/thirdparty/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java:308:
> > if(title.startsWith("~user~")) {
> > On 2017/08/07 09:40:16, anton wrote:
> > > `{` is expected to be in the next line
> > 
> > Acknowledged.
> 
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld