Issue 29508555: Issue 5450 - move FilterEngine into Platform

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29508555: Issue 5450 - move FilterEngine into Platform (Closed)

Created:
Aug. 7, 2017, 8:28 a.m. by sergei

Modified:
Aug. 7, 2017, 2:51 p.m.

Reviewers:
hub

CC:
Felix Dahlke

Base URL:
https://github.com/adblockplus/libadblockplus.git

Visibility:
Public.

Description

# depends on https://codereview.adblockplus.org/29500602/

Patch Set 2 : fix typos #

Created: Aug. 7, 2017, 1:03 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -50 lines)			Patch
M	include/AdblockPlus/FilterEngine.h	View		2 chunks	+2 lines, -9 lines	0 comments	Download
M	include/AdblockPlus/Platform.h	View		4 chunks	+26 lines, -0 lines	0 comments	Download
M	shell/src/Main.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/FilterEngine.cpp	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	src/Platform.cpp	View		1 chunk	+26 lines, -0 lines	0 comments	Download
M	test/BaseJsTest.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/BaseJsTest.cpp	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	test/FilterEngine.cpp	View		7 chunks	+11 lines, -16 lines	0 comments	Download
M	test/Notification.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/Prefs.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/UpdateCheck.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/WebRequest.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

hub

few typos, otherwise looks fine. https://codereview.adblockplus.org/29508555/diff/29508556/test/BaseJsTest.cpp File test/BaseJsTest.cpp (right): https://codereview.adblockplus.org/29508555/diff/29508556/test/BaseJsTest.cpp#newcode39 test/BaseJsTest.cpp:39: Platform& paltform, typo here ...

Aug. 7, 2017, 12:05 p.m. (2017-08-07 12:05:56 UTC) #2

sergei

https://codereview.adblockplus.org/29508555/diff/29508556/test/BaseJsTest.cpp File test/BaseJsTest.cpp (right): https://codereview.adblockplus.org/29508555/diff/29508556/test/BaseJsTest.cpp#newcode39 test/BaseJsTest.cpp:39: Platform& paltform, On 2017/08/07 12:05:56, hub wrote: > typo ...

Aug. 7, 2017, 1:10 p.m. (2017-08-07 13:10:51 UTC) #3

LGTM

Expand All Messages | Collapse All Messages