include/AdblockPlus/FilterEngine.h - Issue 29508569: Issue 5450 - don't expose std::shared_ptr<JsEngine>

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: include/AdblockPlus/FilterEngine.h

Issue 29508569: Issue 5450 - don't expose std::shared_ptr<JsEngine> (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git

Patch Set: Created Aug. 7, 2017, 8:39 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: include/AdblockPlus/FilterEngine.h

diff --git a/include/AdblockPlus/FilterEngine.h b/include/AdblockPlus/FilterEngine.h

index 695b24473134e7aa01258ef7184951f0090d2f00..9952be84abf73295b31723cf453190120b71798a 100644

--- a/include/AdblockPlus/FilterEngine.h

+++ b/include/AdblockPlus/FilterEngine.h

@@ -300,7 +300,7 @@ namespace AdblockPlus

* Retrieves the `JsEngine` instance associated with this `FilterEngine`

* instance.

- JsEnginePtr GetJsEngine() const { return jsEngine; }

+ JsEngine& GetJsEngine() const { return *jsEngine; }

/**

* Checks if this is the first run of the application.

« no previous file with comments | « no previous file | include/AdblockPlus/Platform.h » ('j') | no next file with comments »