Issue 5450 - don't expose std::shared_ptr<FilterEngine>

src/Platform.cpp

 /*
 * This file is part of Adblock Plus <https://adblockplus.org/>,
 * Copyright (C) 2006-2017 eyeo GmbH
 *
 * Adblock Plus is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License version 3 as
 * published by the Free Software Foundation.
 *
 * Adblock Plus is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 77 matching lines @@
       return;
     filterEnginePromise = std::make_shared<std::promise<FilterEnginePtr>>();
     filterEngine = filterEnginePromise->get_future();
   }
 
   GetJsEngine(); // ensures that JsEngine is instantiated
   FilterEngine::CreateAsync(jsEngine, [this, onCreated, filterEnginePromise](const FilterEnginePtr& filterEngine)
   {
     filterEnginePromise->set_value(filterEngine);
     if (onCreated)
-      onCreated(filterEngine);
+      onCreated(*filterEngine);
   }, parameters);
 }
 
-FilterEnginePtr Platform::GetFilterEngine()
+FilterEngine& Platform::GetFilterEngine()
 {
   CreateFilterEngineAsync();
-  return std::shared_future<FilterEnginePtr>(filterEngine).get();
+  return *std::shared_future<FilterEnginePtr>(filterEngine).get();
 }
 
 ITimer& Platform::GetTimer()
 {
   return *timer;
 }
 
 IFileSystem& Platform::GetFileSystem()
 {
   return *fileSystem;
 }
 
 IWebRequest& Platform::GetWebRequest()
 {
   return *webRequest;
 }
 
 LogSystem& Platform::GetLogSystem()
 {
   return *logSystem;
 }