Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29508591: Issue 5450 - don't expose std::shared_ptr<FilterEngine> (Closed)

Created:
Aug. 7, 2017, 8:46 a.m. by sergei
Modified:
Aug. 7, 2017, 2:51 p.m.
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

# depends on https://codereview.adblockplus.org/29508569/

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -226 lines) Patch
M include/AdblockPlus/Platform.h View 2 chunks +2 lines, -2 lines 0 comments Download
M shell/src/Main.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M src/Platform.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M test/BaseJsTest.h View 1 1 chunk +1 line, -1 line 0 comments Download
M test/BaseJsTest.cpp View 1 2 chunks +6 lines, -6 lines 0 comments Download
M test/FilterEngine.cpp View 30 chunks +161 lines, -135 lines 0 comments Download
M test/Notification.cpp View 4 chunks +5 lines, -8 lines 0 comments Download
M test/Prefs.cpp View 8 chunks +52 lines, -56 lines 0 comments Download
M test/UpdateCheck.cpp View 8 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 3
sergei
Aug. 7, 2017, 8:50 a.m. (2017-08-07 08:50:33 UTC) #1
sergei
On 2017/08/07 08:50:33, sergei wrote:
Aug. 7, 2017, 1:09 p.m. (2017-08-07 13:09:42 UTC) #2
hub
Aug. 7, 2017, 1:31 p.m. (2017-08-07 13:31:20 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld