Issue 5450 - don't expose std::shared_ptr<FilterEngine>

test/BaseJsTest.cpp

 /*
 * This file is part of Adblock Plus <https://adblockplus.org/>,
 * Copyright (C) 2006-2017 eyeo GmbH
 *
 * Adblock Plus is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License version 3 as
 * published by the Free Software Foundation.
 *
 * Adblock Plus is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 17 matching lines @@
     if (ii->timeout.count() == 0)
     {
       ii->callback();
       ii = timerTasks->erase(ii);
     }
     else
       ++ii;
   }
 }
 
-FilterEnginePtr CreateFilterEngine(LazyFileSystem& fileSystem,
+FilterEngine& CreateFilterEngine(LazyFileSystem& fileSystem,
   Platform& platform,
   const FilterEngine::CreationParameters& creationParams)
 {
   std::list<LazyFileSystem::Task> fileSystemTasks;
   fileSystem.scheduler = [&fileSystemTasks](const LazyFileSystem::Task& task)
   {
     fileSystemTasks.emplace_back(task);
   };
-  FilterEnginePtr retValue;
-  platform.CreateFilterEngineAsync(creationParams, [&retValue, &fileSystem](const FilterEnginePtr& filterEngine)
+  bool isFilterEngineReady = false;
+  platform.CreateFilterEngineAsync(creationParams, [&isFilterEngineReady, &fileSystem](const FilterEngine& filterEngine)
   {
-    retValue = filterEngine;
     fileSystem.scheduler = LazyFileSystem::ExecuteImmediately;
+    isFilterEngineReady = true;
   });
-  while (!retValue && !fileSystemTasks.empty())
+  while (!isFilterEngineReady && !fileSystemTasks.empty())
   {
     (*fileSystemTasks.begin())();
     fileSystemTasks.pop_front();
   }
-  return retValue;
+  return platform.GetFilterEngine();
 }
 
 ThrowingPlatformCreationParameters::ThrowingPlatformCreationParameters()
 {
   logSystem.reset(new ThrowingLogSystem());
   timer.reset(new ThrowingTimer());
   fileSystem = std::make_shared<ThrowingFileSystem>();
   webRequest.reset(new ThrowingWebRequest());
 }