shell/src/Main.cpp - Issue 29508591: Issue 5450 - don't expose std::shared_ptr<FilterEngine>

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: shell/src/Main.cpp

Issue 29508591: Issue 5450 - don't expose std::shared_ptr<FilterEngine> (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git

Patch Set: Created Aug. 7, 2017, 8:46 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: shell/src/Main.cpp

diff --git a/shell/src/Main.cpp b/shell/src/Main.cpp

index 5e26f625cdfdd674df9773ba2343e97e73c28b0d..16b136313839b2cee1802a850843387acfd15f4c 100644

--- a/shell/src/Main.cpp

+++ b/shell/src/Main.cpp

@@ -66,15 +66,15 @@ int main()

AdblockPlus::Platform platform;

platform.SetUpJsEngine(appInfo);

AdblockPlus::JsEngine& jsEngine = platform.GetJsEngine();

- auto filterEngine = platform.GetFilterEngine();

+ auto& filterEngine = platform.GetFilterEngine();

CommandMap commands;

Add(commands, new GcCommand(jsEngine));

Add(commands, new HelpCommand(commands));

- Add(commands, new FiltersCommand(*filterEngine));

- Add(commands, new SubscriptionsCommand(*filterEngine));

- Add(commands, new MatchesCommand(*filterEngine));

- Add(commands, new PrefsCommand(*filterEngine));

+ Add(commands, new FiltersCommand(filterEngine));

+ Add(commands, new SubscriptionsCommand(filterEngine));

+ Add(commands, new MatchesCommand(filterEngine));

+ Add(commands, new PrefsCommand(filterEngine));

std::string commandLine;

while (ReadCommandLine(commandLine))

« no previous file with comments | « include/AdblockPlus/Platform.h ('k') | src/Platform.cpp » ('j') | no next file with comments »