Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/Platform.h

Issue 29508591: Issue 5450 - don't expose std::shared_ptr<FilterEngine> (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: rebase Created Aug. 7, 2017, 1:08 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | shell/src/Main.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/AdblockPlus/Platform.h
diff --git a/include/AdblockPlus/Platform.h b/include/AdblockPlus/Platform.h
index 9c89eda556d28d207a33600bda25f2e76e851ce5..0328c4cb4fbc9ce550c7c905b7c755aea0c38c47 100644
--- a/include/AdblockPlus/Platform.h
+++ b/include/AdblockPlus/Platform.h
@@ -81,7 +81,7 @@ namespace AdblockPlus
/**
* Callback type invoked when FilterEngine is created.
*/
- typedef std::function<void(const FilterEnginePtr&)> OnFilterEngineCreatedCallback;
+ typedef std::function<void(const FilterEngine&)> OnFilterEngineCreatedCallback;
/**
* Platform constructor.
@@ -122,7 +122,7 @@ namespace AdblockPlus
* operations, please ensure that provided implementation does not lead to
* a dead lock.
*/
- FilterEnginePtr GetFilterEngine();
+ FilterEngine& GetFilterEngine();
/**
* @return The asynchronous ITimer implementation.
« no previous file with comments | « no previous file | shell/src/Main.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld