Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(186)

Issue 29509573: Issue 5347 - Check for browserAction API support (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by Manish Jethani
Modified:
2 years, 1 month ago
CC:
Thomas Greiner
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Issue 5347 - Check for browserAction API support Firefox for Android does not support chrome.browserAction.setBadgeBackgroundColor, chrome.browserAction.setBadgeText, and chrome.browserAction.setIcon.

Patch Set 1 #

Patch Set 2 : Use consistent style for feature detection #

Total comments: 2

Patch Set 3 : Add comments explaining why Firefox for Android does not support these APIs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -19 lines) Patch
M ext/background.js View 1 2 1 chunk +36 lines, -19 lines 0 comments Download

Messages

Total messages: 9
Manish Jethani
2 years, 1 month ago (2017-08-08 11:38:28 UTC) #1
Manish Jethani
Firefox for Android does not support chrome.browserAction.setBadgeBackgroundColor, chrome.browserAction.setBadgeText, and chrome.browserAction.setIcon. Note that we could display ...
2 years, 1 month ago (2017-08-08 11:43:12 UTC) #2
Manish Jethani
I've added Thomas here as he might have something to say about this. The "browser ...
2 years, 1 month ago (2017-08-10 06:35:24 UTC) #3
Manish Jethani
Patch Set 2: Use consistent style for feature detection
2 years, 1 month ago (2017-08-15 23:57:34 UTC) #4
Manish Jethani
Patch Set 2: Use consistent style for feature detection
2 years, 1 month ago (2017-08-15 23:57:36 UTC) #5
Wladimir Palant
https://codereview.adblockplus.org/29509573/diff/29516682/ext/background.js File ext/background.js (right): https://codereview.adblockplus.org/29509573/diff/29516682/ext/background.js#newcode330 ext/background.js:330: if ("setIcon" in chrome.browserAction) Here and below, maybe add ...
2 years, 1 month ago (2017-08-16 10:52:07 UTC) #6
Manish Jethani
Patch Set 3: Add comments explaining why Firefox for Android does not support these APIs ...
2 years, 1 month ago (2017-08-16 11:45:42 UTC) #7
Wladimir Palant
LGTM
2 years, 1 month ago (2017-08-16 11:51:43 UTC) #8
Sebastian Noack
2 years, 1 month ago (2017-08-18 09:18:29 UTC) #9
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5