Issue 5347 - Check for browserAction API support

Issue 5347 - Check for browserAction API support

Firefox for Android does not support chrome.browserAction.setBadgeBackgroundColor, chrome.browserAction.setBadgeText, and chrome.browserAction.setIcon.

[Manish Jethani, 2017-08-08 11:43:12]

Firefox for Android does not support
chrome.browserAction.setBadgeBackgroundColor, chrome.browserAction.setBadgeText,
and chrome.browserAction.setIcon.

Note that we could display the badge text in the menu item that appears in place
of the toolbar button, by calling chrome.browserAction.setTitle and including
the number in brackets. This is a design change though, and presumably we'd want
to localize the number as well. It's outside of the scope of what we're trying
to do here (i.e. fix errors and get it working on Android).

[Manish Jethani, 2017-08-10 06:35:24]

I've added Thomas here as he might have something to say about this.

The "browser action" in Firefox for Android is just a menu item instead of a
toolbar button. By default nothing happens when you click on it. I think we want
to add an onClicked handler and call chrome.runtime.openOptionsPage in it, but
I'm not sure and I think Thomas is already working on this.

[Manish Jethani, 2017-08-15 23:57:34]

Patch Set 2: Use consistent style for feature detection

[Manish Jethani, 2017-08-15 23:57:36]

Patch Set 2: Use consistent style for feature detection

[Wladimir Palant, 2017-08-16 10:52:07]

https://codereview.adblockplus.org/29509573/diff/29516682/ext/background.js
File ext/background.js (right):

https://codereview.adblockplus.org/29509573/diff/29516682/ext/background.js#n...
ext/background.js:330: if ("setIcon" in chrome.browserAction)
Here and below, maybe add a comment explaining which applications don't
currently have this feature? You can also link to
https://bugzilla.mozilla.org/show_bug.cgi?id=1331746 here. It helps knowing when
we can remove the check.

[Manish Jethani, 2017-08-16 11:45:42]

Patch Set 3: Add comments explaining why Firefox for Android does not support
these APIs

https://codereview.adblockplus.org/29509573/diff/29516682/ext/background.js
File ext/background.js (right):

https://codereview.adblockplus.org/29509573/diff/29516682/ext/background.js#n...
ext/background.js:330: if ("setIcon" in chrome.browserAction)
On 2017/08/16 10:52:07, Wladimir Palant wrote:
> Here and below, maybe add a comment explaining which applications don't
> currently have this feature? You can also link to
> https://bugzilla.mozilla.org/show_bug.cgi?id=1331746 here. It helps knowing
when
> we can remove the check.

Done.

[Wladimir Palant, 2017-08-16 11:51:43]

LGTM

[Sebastian Noack, 2017-08-18 09:18:29]

LGTM