Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29510587: Issue 5366 - Reach full legal compliance in ABP for Samsung Internet (Closed)

Created:
Aug. 9, 2017, 3:20 p.m. by jens
Modified:
Aug. 15, 2017, 10:14 a.m.
Reviewers:
anton, diegocarloslima
CC:
Felix Dahlke, René Jeschke
Visibility:
Public.

Description

Issue 5366 - Reach full legal compliance in ABP for Samsung Internet

Patch Set 1 : Issue 5366 - Reach full legal compliance in ABP for Samsung Internet #

Total comments: 4

Patch Set 2 : Fixed copyright text and xml formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -0 lines) Patch
A adblockplussbrowser/res/layout/imprint_screen.xml View 1 1 chunk +10 lines, -0 lines 0 comments Download
M adblockplussbrowser/res/values/strings.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M adblockplussbrowser/res/values/sysstrings.xml View 1 chunk +4 lines, -0 lines 0 comments Download
M adblockplussbrowser/res/xml/preferences_main.xml View 1 chunk +16 lines, -0 lines 0 comments Download
A adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/preferences/ImprintPreference.java View 1 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 5
jens
Aug. 10, 2017, 7:12 a.m. (2017-08-10 07:12:30 UTC) #1
anton
https://codereview.adblockplus.org/29510587/diff/29511555/adblockplussbrowser/res/layout/imprint_screen.xml File adblockplussbrowser/res/layout/imprint_screen.xml (right): https://codereview.adblockplus.org/29510587/diff/29511555/adblockplussbrowser/res/layout/imprint_screen.xml#newcode5 adblockplussbrowser/res/layout/imprint_screen.xml:5: > can we have `>` on the previous line ...
Aug. 11, 2017, 11:20 a.m. (2017-08-11 11:20:39 UTC) #2
jens
https://codereview.adblockplus.org/29510587/diff/29511555/adblockplussbrowser/res/layout/imprint_screen.xml File adblockplussbrowser/res/layout/imprint_screen.xml (right): https://codereview.adblockplus.org/29510587/diff/29511555/adblockplussbrowser/res/layout/imprint_screen.xml#newcode5 adblockplussbrowser/res/layout/imprint_screen.xml:5: > On 2017/08/11 11:20:38, anton wrote: > can we ...
Aug. 11, 2017, 1:27 p.m. (2017-08-11 13:27:34 UTC) #3
anton
On 2017/08/11 13:27:34, jens wrote: > https://codereview.adblockplus.org/29510587/diff/29511555/adblockplussbrowser/res/layout/imprint_screen.xml > File adblockplussbrowser/res/layout/imprint_screen.xml (right): > > https://codereview.adblockplus.org/29510587/diff/29511555/adblockplussbrowser/res/layout/imprint_screen.xml#newcode5 > ...
Aug. 11, 2017, 1:31 p.m. (2017-08-11 13:31:30 UTC) #4
diegocarloslima
Aug. 14, 2017, 6:01 p.m. (2017-08-14 18:01:45 UTC) #5 
On 2017/08/11 13:31:30, anton wrote:
> On 2017/08/11 13:27:34, jens wrote:
> >
>
https://codereview.adblockplus.org/29510587/diff/29511555/adblockplussbrowser...
> > File adblockplussbrowser/res/layout/imprint_screen.xml (right):
> > 
> >
>
https://codereview.adblockplus.org/29510587/diff/29511555/adblockplussbrowser...
> > adblockplussbrowser/res/layout/imprint_screen.xml:5: >
> > On 2017/08/11 11:20:38, anton wrote:
> > > can we have `>` on the previous line (at the end)?
> > 
> > Acknowledged.
> > 
> >
>
https://codereview.adblockplus.org/29510587/diff/29511555/adblockplussbrowser...
> > File
> >
>
adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/preferences/ImprintPreference.java
> > (right):
> > 
> >
>
https://codereview.adblockplus.org/29510587/diff/29511555/adblockplussbrowser...
> >
>
adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/preferences/ImprintPreference.java:3:
> > * Copyright (C) 2006-2017 Eyeo GmbH
> > On 2017/08/11 11:20:38, anton wrote:
> > > please double check `E` - i believe it should be 'e', not capital 'E').
> > > consider fixing it in separate issue (noissue) if using capital 'E' in all
> the
> > > files.
> > 
> > Acknowledged.
> 
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld