Issue 29510630: Noissue - Added canonical link to standard meta template

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29510630: Noissue - Added canonical link to standard meta template (Closed)

Created:
Aug. 9, 2017, 7:24 p.m. by juliandoucette

Modified:
Aug. 22, 2017, 1:12 p.m.

Reviewers:
ire, saroyanm

Base URL:
https://hg.adblockplus.org/website-defaults

Visibility:
Public.

Description

Noissue - Added canonical link to standard meta template

Patch Set 1 #

Patch Set 2 : Added siteurl and include to default.tmpl #

Created: Aug. 21, 2017, 10:43 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
M	includes/meta/standard.tmpl	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	settings.ini	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	templates/default.tmpl	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

juliandoucette

I think canonical link is standard enough to make our standard meta template.

Aug. 9, 2017, 7:25 p.m. (2017-08-09 19:25:33 UTC) #2

ire

On 2017/08/09 19:25:33, juliandoucette wrote: > I think canonical link is standard enough to make ...

Aug. 10, 2017, 9:10 a.m. (2017-08-10 09:10:45 UTC) #3

juliandoucette

On 2017/08/10 09:10:45, ire wrote: > 1. Since this function requires `siteurl` to work, should ...

Aug. 21, 2017, 10:44 a.m. (2017-08-21 10:44:09 UTC) #4

ire

Aug. 22, 2017, 8:42 a.m. (2017-08-22 08:42:25 UTC) #5

On 2017/08/21 10:44:09, juliandoucette wrote:
> On 2017/08/10 09:10:45, ire wrote:
> > 1. Since this function requires `siteurl` to work, should we include a
default
> > one in website-defaults settings as well? Otherwise, starting the site will
> > throw an error. 
> 
> Done.
> 
> > 2. Also, related, this file isn't currently being included in the <head> of
> the
> > default template.
> 
> Done.

LGTM

Expand All Messages | Collapse All Messages