Issue 5475 - Update adblockpluscore dependency to revision hg:b935a0402215

test/FileSystemJsObject.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <sstream>
 #include "BaseJsTest.h"
 #include "../src/Thread.h"
 
 namespace
 {
   class MockFileSystem : public AdblockPlus::IFileSystem
   {
   public:
     bool success;
     IOBuffer contentToRead;
-    std::string lastWrittenPath;
+    std::string lastWrittenFile;
     IOBuffer lastWrittenContent;
     std::string movedFrom;
     std::string movedTo;
-    std::string removedPath;
-    mutable std::string statPath;
+    std::string removedFile;
+    mutable std::string statFile;
     bool statExists;
-    bool statIsDirectory;
-    bool statIsFile;
     int statLastModified;
 
     MockFileSystem() : success(true)
     {
     }
 
-    void Read(const std::string& path, const ReadCallback& callback) const override
+    void Read(const std::string& fileName, const ReadCallback& callback) const override
     {
       if (!success)
       {
-        callback(IOBuffer(), "Unable to read " + path);
+        callback(IOBuffer(), "Unable to read " + fileName);
         return;
       }
       callback(IOBuffer(contentToRead), "");
     }
 
-    void Write(const std::string& path, const IOBuffer& data,
+    void Write(const std::string& fileName, const IOBuffer& data,
                const Callback& callback) override
     {
       if (!success)
       {
-        callback("Unable to write to " + path);
+        callback("Unable to write to " + fileName);
         return;
       }
-      lastWrittenPath = path;
+      lastWrittenFile = fileName;
 
       lastWrittenContent = data;
       callback("");
     }
 
-    void Move(const std::string& fromPath, const std::string& toPath,
+    void Move(const std::string& fromFileName, const std::string& toFileName,
               const Callback& callback) override
     {
       if (!success)
       {
-        callback("Unable to move " + fromPath + " to " + toPath);
+        callback("Unable to move " + fromFileName + " to " + toFileName);
         return;
       }
-      movedFrom = fromPath;
-      movedTo = toPath;
+      movedFrom = fromFileName;
+      movedTo = toFileName;
       callback("");
     }
 
-    void Remove(const std::string& path, const Callback& callback) override
+    void Remove(const std::string& fileName, const Callback& callback) override
     {
       if (!success)
       {
-        callback("Unable to remove " + path);
+        callback("Unable to remove " + fileName);
         return;
       }
-      removedPath = path;
+      removedFile = fileName;
       callback("");
     }
 
-    void Stat(const std::string& path, const StatCallback& callback) const override
+    void Stat(const std::string& fileName, const StatCallback& callback) const override
     {
       StatResult result;
       std::string error;
       if (!success)
-        error = "Unable to stat " + path;
+        error = "Unable to stat " + fileName;
       else
       {
-        statPath = path;
+        statFile = fileName;
         result.exists = statExists;
-        result.isDirectory = statIsDirectory;
-        result.isFile = statIsFile;
         result.lastModified = statLastModified;
       }
       callback(result, error);
     }
-
-    std::string Resolve(const std::string& path) const override
-    {
-      if (!success)
-        throw std::runtime_error("Unable to stat " + path);
-      return path;
-    }
   };
 
   void ReadFile(AdblockPlus::JsEngine& jsEngine, std::string& content,
                 std::string& error)
   {
     jsEngine.Evaluate("_fileSystem.read('', function(r) {result = r})");
     content = jsEngine.Evaluate("result.content").AsString();
     error = jsEngine.Evaluate("result.error").AsString();
   }
 
@@ skipping 37 matching lines @@
   std::string content;
   std::string error;
   ReadFile(GetJsEngine(), content, error);
   ASSERT_NE("", error);
   ASSERT_EQ("", content);
 }
 
 TEST_F(FileSystemJsObjectTest, Write)
 {
   GetJsEngine().Evaluate("_fileSystem.write('foo', 'bar', function(e) {error = e})");
-  ASSERT_EQ("foo", mockFileSystem->lastWrittenPath);
+  ASSERT_EQ("foo", mockFileSystem->lastWrittenFile);
   ASSERT_EQ((AdblockPlus::IFileSystem::IOBuffer{'b', 'a', 'r'}),
             mockFileSystem->lastWrittenContent);
   ASSERT_TRUE(GetJsEngine().Evaluate("error").IsUndefined());
 }
 
 TEST_F(FileSystemJsObjectTest, WriteIllegalArguments)
 {
   ASSERT_ANY_THROW(GetJsEngine().Evaluate("_fileSystem.write()"));
   ASSERT_ANY_THROW(GetJsEngine().Evaluate("_fileSystem.write('', '', '')"));
 }
@@ skipping 22 matching lines @@
 TEST_F(FileSystemJsObjectTest, MoveError)
 {
   mockFileSystem->success = false;
   GetJsEngine().Evaluate("_fileSystem.move('foo', 'bar', function(e) {error = e})");
   ASSERT_FALSE(GetJsEngine().Evaluate("error").IsUndefined());
 }
 
 TEST_F(FileSystemJsObjectTest, Remove)
 {
   GetJsEngine().Evaluate("_fileSystem.remove('foo', function(e) {error = e})");
-  ASSERT_EQ("foo", mockFileSystem->removedPath);
+  ASSERT_EQ("foo", mockFileSystem->removedFile);
   ASSERT_TRUE(GetJsEngine().Evaluate("error").IsUndefined());
 }
 
 TEST_F(FileSystemJsObjectTest, RemoveIllegalArguments)
 {
   ASSERT_ANY_THROW(GetJsEngine().Evaluate("_fileSystem.remove()"));
   ASSERT_ANY_THROW(GetJsEngine().Evaluate("_fileSystem.remove('', '')"));
 }
 
 TEST_F(FileSystemJsObjectTest, RemoveError)
 {
   mockFileSystem->success = false;
   GetJsEngine().Evaluate("_fileSystem.remove('foo', function(e) {error = e})");
   ASSERT_NE("", GetJsEngine().Evaluate("error").AsString());
 }
 
 TEST_F(FileSystemJsObjectTest, Stat)
 {
   mockFileSystem->statExists = true;
-  mockFileSystem->statIsDirectory= false;
-  mockFileSystem->statIsFile = true;
   mockFileSystem->statLastModified = 1337;
   GetJsEngine().Evaluate("_fileSystem.stat('foo', function(r) {result = r})");
-  ASSERT_EQ("foo", mockFileSystem->statPath);
+  ASSERT_EQ("foo", mockFileSystem->statFile);
   ASSERT_TRUE(GetJsEngine().Evaluate("result.error").IsUndefined());
   ASSERT_TRUE(GetJsEngine().Evaluate("result.exists").AsBool());
-  ASSERT_FALSE(GetJsEngine().Evaluate("result.isDirectory").AsBool());
-  ASSERT_TRUE(GetJsEngine().Evaluate("result.isFile").AsBool());
   ASSERT_EQ(1337, GetJsEngine().Evaluate("result.lastModified").AsInt());
 }
 
 TEST_F(FileSystemJsObjectTest, StatIllegalArguments)
 {
   ASSERT_ANY_THROW(GetJsEngine().Evaluate("_fileSystem.stat()"));
   ASSERT_ANY_THROW(GetJsEngine().Evaluate("_fileSystem.stat('', '')"));
 }
 
 TEST_F(FileSystemJsObjectTest, StatError)
 {
   mockFileSystem->success = false;
   GetJsEngine().Evaluate("_fileSystem.stat('foo', function(r) {result = r})");
   ASSERT_FALSE(GetJsEngine().Evaluate("result.error").IsUndefined());
 }