Issue 5475 - Update adblockpluscore dependency to revision hg:b935a0402215

[sergei, 2017-08-11 12:49:39]

https://codereview.adblockplus.org/29512648/diff/29512649/include/AdblockPlus...
File include/AdblockPlus/FilterEngine.h (right):

https://codereview.adblockplus.org/29512648/diff/29512649/include/AdblockPlus...
include/AdblockPlus/FilterEngine.h:54: TYPE_TYPE_ELEMHIDE_EMULATION,
Meanwhile I have merely added this filter type to the enumeration but the actual
support of it should be done as #5498.

https://codereview.adblockplus.org/29512648/diff/29512649/include/AdblockPlus...
include/AdblockPlus/FilterEngine.h:210: CONTENT_TYPE_WEBRTC = 256,
Tests will be done as #5499.

https://codereview.adblockplus.org/29512648/diff/29512649/include/AdblockPlus...
File include/AdblockPlus/IFileSystem.h (right):

https://codereview.adblockplus.org/29512648/diff/29512649/include/AdblockPlus...
include/AdblockPlus/IFileSystem.h:1: /*
For changes related to this interface please refer to #5059.

https://codereview.adblockplus.org/29512648/diff/29512649/include/AdblockPlus...
File include/AdblockPlus/Notification.h (right):

https://codereview.adblockplus.org/29512648/diff/29512649/include/AdblockPlus...
include/AdblockPlus/Notification.h:35: NOTIFICATION_TYPE_RELENTLESS,
Tests will be done as #5500.

https://codereview.adblockplus.org/29512648/diff/29512649/lib/api.js
File lib/api.js (right):

https://codereview.adblockplus.org/29512648/diff/29512649/lib/api.js#newcode196
lib/api.js:196: return ElemHide.getSelectorsForDomain(domain,
ElemHide.ALL_MATCHING, false);
see
https://github.com/adblockplus/adblockpluscore/commit/e0e5b803a7eea19fcb7e18b...

https://codereview.adblockplus.org/29512648/diff/29512649/lib/compat.js
File lib/compat.js (left):

https://codereview.adblockplus.org/29512648/diff/29512649/lib/compat.js#oldco...
lib/compat.js:51: nsIFile: {DIRECTORY_TYPE: 0},
Some parts of Components seem to be removed long ago but were still there.
Before removing them I have ensured that grep does not find these parts neither
in "./adblockpluscore/lib" nor in "./lib".

https://codereview.adblockplus.org/29512648/diff/29512649/lib/compat.js#oldco...
lib/compat.js:106: function FakeFile(path)
Removed because of #5059

https://codereview.adblockplus.org/29512648/diff/29512649/lib/compat.js
File lib/compat.js (right):

https://codereview.adblockplus.org/29512648/diff/29512649/lib/compat.js#newco...
lib/compat.js:72: let match =
/^resource:\/\/gre\/modules\/(.+)\.jsm$/.exec(resource);
it's taken from
https://github.com/adblockplus/adblockpluschrome/commit/1464f45e948974cb58d34...

https://codereview.adblockplus.org/29512648/diff/29512649/lib/prefs.js
File lib/prefs.js (left):

https://codereview.adblockplus.org/29512648/diff/29512649/lib/prefs.js#oldcode25
lib/prefs.js:25: patternsfile: "patterns.ini",
now it's hardcoded in adblockpluscore/lib/filtersStorage.js, data_directory is
not used at all.

https://codereview.adblockplus.org/29512648/diff/29512649/lib/prefs.js#oldcode56
lib/prefs.js:56: let path = _fileSystem.resolve("prefs.json");
it's renamed because file system does not support paths, it works only with file
names.

[sergei, 2017-08-11 14:43:11]

https://codereview.adblockplus.org/29512648/diff/29512649/libadblockplus.gyp
File libadblockplus.gyp (right):

https://codereview.adblockplus.org/29512648/diff/29512649/libadblockplus.gyp#...
libadblockplus.gyp:136: 'lib/init.js',
BTW, the core now has RSA (git 56fcfd105b9e09d308dd8953bd9ef3ad0ef9d113),
however it seems it's not used, so corresponding JS files are not loaded.

[hub, 2017-08-11 14:52:59]

LGTM