Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/FileSystemJsObject.cpp

Issue 29512648: Issue 5475 - Update adblockpluscore dependency to revision hg:b935a0402215 (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: Created Aug. 11, 2017, 12:36 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/FileSystemJsObject.cpp
diff --git a/src/FileSystemJsObject.cpp b/src/FileSystemJsObject.cpp
index 6744d7d820cb84eae2aa410dc3d59ee1b83ad6d2..1f9ed739c22ba0e06fec9d6ed54bf832a297c80a 100644
--- a/src/FileSystemJsObject.cpp
+++ b/src/FileSystemJsObject.cpp
@@ -183,8 +183,6 @@ namespace
auto result = jsEngine->NewObject();
result.SetProperty("exists", statResult.exists);
- result.SetProperty("isFile", statResult.isFile);
- result.SetProperty("isDirectory", statResult.isDirectory);
result.SetProperty("lastModified", statResult.lastModified);
if (!error.empty())
result.SetProperty("error", error);
@@ -194,19 +192,6 @@ namespace
jsEngine->TakeJsValues(weakCallback)[0].Call(params);
});
}
-
- void ResolveCallback(const v8::FunctionCallbackInfo<v8::Value>& arguments)
- {
- AdblockPlus::JsEnginePtr jsEngine = AdblockPlus::JsEngine::FromArguments(arguments);
- AdblockPlus::JsValueList converted = jsEngine->ConvertArguments(arguments);
-
- v8::Isolate* isolate = arguments.GetIsolate();
- if (converted.size() != 1)
- return ThrowExceptionInJS(isolate, "_fileSystem.resolve requires 1 parameter");
-
- std::string resolved = jsEngine->GetPlatform().GetFileSystem().Resolve(converted[0].AsString());
- arguments.GetReturnValue().Set(Utils::ToV8String(isolate, resolved));
- }
}
@@ -217,6 +202,5 @@ JsValue& FileSystemJsObject::Setup(JsEngine& jsEngine, JsValue& obj)
obj.SetProperty("move", jsEngine.NewCallback(::MoveCallback));
obj.SetProperty("remove", jsEngine.NewCallback(::RemoveCallback));
obj.SetProperty("stat", jsEngine.NewCallback(::StatCallback));
- obj.SetProperty("resolve", jsEngine.NewCallback(::ResolveCallback));
return obj;
}
« libadblockplus.gyp ('K') | « src/DefaultFileSystem.cpp ('k') | src/FilterEngine.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld