Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: static/scss/layout/_body.scss

Issue 29516622: Issue 5511 - Create Product Help Home Template for help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Patch Set: Created Aug. 15, 2017, 3:01 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: static/scss/layout/_body.scss
===================================================================
--- a/static/scss/layout/_body.scss
+++ b/static/scss/layout/_body.scss
@@ -11,11 +11,41 @@
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>.
.outer
{
- min-height: 100vh; // For testing purposes. Will remove.
margin-top: $site-header-height;
+ background-image: url("/img/png/help-bg.png");
juliandoucette 2017/08/24 11:14:01 NIT: Apparently our code style guide suggests no q
ire 2017/08/28 14:54:49 Oh okay. I thought it was the other way around, I
juliandoucette 2017/09/12 13:21:53 That's probably my fault :D (or, at least, you can
+ background-repeat: no-repeat;
}
+
+.main
juliandoucette 2017/08/24 11:14:00 NIT: Isn't there usually only one <main> or #main?
ire 2017/08/28 14:54:49 Changed to #main
+{
+ padding-top: $lg;
+ padding-bottom: $xl;
+
+ @media (min-width: $mobile-breakpoint)
+ {
+ padding-top: $xl;
+ }
+}
+
+.wrapper
juliandoucette 2017/08/24 11:14:01 NIT: If you agree with my comment about .nav-wrapp
ire 2017/08/28 14:54:48 Okay, I think it makes sense to update this when t
+{
+ width: $content-width;
+ max-width: $content-max-width;
+ margin-right: auto;
+ margin-left: auto;
+}
+
+.section
+{
+ margin-bottom: $lg;
+
+ @media (min-width: $mobile-breakpoint)
+ {
+ margin-bottom: $xl;
+ }
+}

Powered by Google App Engine
This is Rietveld