Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29516679: Issue 5347 - Do not show composer menu item on Firefox for Android (Closed)

Created:
Aug. 15, 2017, 11:40 p.m. by Manish Jethani
Modified:
Aug. 24, 2017, 11:23 a.m.
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Issue 5347 - Do not show composer menu item on Firefox for Android

Patch Set 1 #

Total comments: 2

Patch Set 2 : Check for chrome.windows instead #

Total comments: 6

Patch Set 3 : Check for "Fennec" explicitly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M lib/filterComposer.js View 1 2 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 11
Manish Jethani
Aug. 15, 2017, 11:41 p.m. (2017-08-15 23:41:03 UTC) #1
Manish Jethani
Patch Set 1 https://codereview.adblockplus.org/29516679/diff/29516680/lib/filterComposer.js File lib/filterComposer.js (right): https://codereview.adblockplus.org/29516679/diff/29516680/lib/filterComposer.js#newcode190 lib/filterComposer.js:190: // Disable the composer if the ...
Aug. 15, 2017, 11:50 p.m. (2017-08-15 23:50:06 UTC) #2
Manish Jethani
Patch Set 2: Check for chrome.windows instead As discussed, we can just check for chrome.windows, ...
Aug. 16, 2017, 8:18 p.m. (2017-08-16 20:18:00 UTC) #3
Wladimir Palant
https://codereview.adblockplus.org/29516679/diff/29517759/lib/filterComposer.js File lib/filterComposer.js (right): https://codereview.adblockplus.org/29516679/diff/29517759/lib/filterComposer.js#newcode185 lib/filterComposer.js:185: // required for the composer to work. Not really, ...
Aug. 17, 2017, 12:22 p.m. (2017-08-17 12:22:49 UTC) #4
Manish Jethani
https://codereview.adblockplus.org/29516679/diff/29517759/lib/filterComposer.js File lib/filterComposer.js (right): https://codereview.adblockplus.org/29516679/diff/29517759/lib/filterComposer.js#newcode185 lib/filterComposer.js:185: // required for the composer to work. On 2017/08/17 ...
Aug. 17, 2017, 1:25 p.m. (2017-08-17 13:25:19 UTC) #5
Sebastian Noack
https://codereview.adblockplus.org/29516679/diff/29517759/lib/filterComposer.js File lib/filterComposer.js (right): https://codereview.adblockplus.org/29516679/diff/29517759/lib/filterComposer.js#newcode185 lib/filterComposer.js:185: // required for the composer to work. On 2017/08/17 ...
Aug. 18, 2017, 9:23 a.m. (2017-08-18 09:23:01 UTC) #6
Wladimir Palant
LGTM https://codereview.adblockplus.org/29516679/diff/29517759/lib/filterComposer.js File lib/filterComposer.js (right): https://codereview.adblockplus.org/29516679/diff/29517759/lib/filterComposer.js#newcode185 lib/filterComposer.js:185: // required for the composer to work. On ...
Aug. 18, 2017, 8:52 p.m. (2017-08-18 20:52:32 UTC) #7
Sebastian Noack
https://codereview.adblockplus.org/29516679/diff/29517759/lib/filterComposer.js File lib/filterComposer.js (right): https://codereview.adblockplus.org/29516679/diff/29517759/lib/filterComposer.js#newcode185 lib/filterComposer.js:185: // required for the composer to work. On 2017/08/18 ...
Aug. 23, 2017, noon (2017-08-23 12:00:35 UTC) #8
Manish Jethani
Patch Set 3: Check for "Fennec" explicitly https://codereview.adblockplus.org/29516679/diff/29517759/lib/filterComposer.js File lib/filterComposer.js (right): https://codereview.adblockplus.org/29516679/diff/29517759/lib/filterComposer.js#newcode185 lib/filterComposer.js:185: // required ...
Aug. 24, 2017, 10:34 a.m. (2017-08-24 10:34:59 UTC) #9
Sebastian Noack
LGTM
Aug. 24, 2017, 10:46 a.m. (2017-08-24 10:46:48 UTC) #10
Wladimir Palant
Aug. 24, 2017, 11:09 a.m. (2017-08-24 11:09:54 UTC) #11
LGTM

Powered by Google App Engine
This is Rietveld