Issue 5515 - Adblock Plus Frontend Developer Job Description to upload on our Website

Issue 5515 - Adblock Plus Frontend Developer Job Description to upload on our Website

[ire, 2017-08-21 10:53:25]

Ready

[juliandoucette, 2017-08-22 13:25:26]

LGTM

@Thomas will you please confirm that you have reviewed this content and you are
fine with publishing this as-is.

[Thomas Greiner, 2017-08-22 17:54:32]

Yep, I reviewed the content.

It appears to contain some odd punctuation and such but that's for someone else
to judge.

[ire, 2017-08-24 07:35:26]

On 2017/08/22 17:54:32, Thomas Greiner wrote:
> Yep, I reviewed the content.
> 
> It appears to contain some odd punctuation and such but that's for someone
else
> to judge.

Thanks Thomas

@Lisa could you please have a look at the content here, it was marked as
reviewed in the issue but this may not be the case.

[Lisa, 2017-08-24 13:07:49]

Hi Ire,

I made a few suggestions.

Thanks!

https://codereview.adblockplus.org/29522597/diff/29522598/pages/jobs/adblock-...
File pages/jobs/adblock-plus-frontend-developer.md (right):

https://codereview.adblockplus.org/29522597/diff/29522598/pages/jobs/adblock-...
pages/jobs/adblock-plus-frontend-developer.md:2: description=We offer a chance
to be a part of the ABP UI family; work, develop, test, create, improve, laugh &
curse in different languages – Front-end developers unite!
description=Be a part of the ABP UI family. Work, develop, test, create,
improve, laugh and curse in different languages. Frontend developers unite!

https://codereview.adblockplus.org/29522597/diff/29522598/pages/jobs/adblock-...
pages/jobs/adblock-plus-frontend-developer.md:16: 100 million people are looking
for you. Yes! 100 million people, every day, looking for you. If every one of
them wrote ‘Thank you!’ on your profile page you would have a billion new
characters instantly. It would look like a mess sure, but it would feel so good!
I don't really understand this paragraph, but in any case, I'd at least change
'100 million' to 'One hundred million' since it's at the beginning of the
sentence.

One hundred million people are looking for you. Yes! One hundred million people,
every day, looking for YOU.

https://codereview.adblockplus.org/29522597/diff/29522598/pages/jobs/adblock-...
pages/jobs/adblock-plus-frontend-developer.md:18: That’s basically what we
offer, a chance to be a part of the ABP family; work, develop, test, create,
improve, laugh, laugh in different languages, curse in different languages – all
the good things of being part of a team of capable developers.
That’s basically what we offer, a chance to be a part of the ABP family. Work,
develop, test, create, improve, laugh in different languages, curse in different
languages – all the good things of being part of a team of capable developers.

https://codereview.adblockplus.org/29522597/diff/29522598/pages/jobs/adblock-...
pages/jobs/adblock-plus-frontend-developer.md:22: - Writing code for ABP UI
various platforms, handling aspects like: first run page, options page, icon
pop-up, issue reporter, etc.
Options page

https://codereview.adblockplus.org/29522597/diff/29522598/pages/jobs/adblock-...
pages/jobs/adblock-plus-frontend-developer.md:25: - Bouncing ideas within the
team, making architectural changes.
remove the period after 'changes'

[ire, 2017-08-24 13:45:27]

Thanks Lisa!

Julian, is this good to go?

https://codereview.adblockplus.org/29522597/diff/29522598/pages/jobs/adblock-...
File pages/jobs/adblock-plus-frontend-developer.md (right):

https://codereview.adblockplus.org/29522597/diff/29522598/pages/jobs/adblock-...
pages/jobs/adblock-plus-frontend-developer.md:2: description=We offer a chance
to be a part of the ABP UI family; work, develop, test, create, improve, laugh &
curse in different languages – Front-end developers unite!
On 2017/08/24 13:07:48, Lisa wrote:
> description=Be a part of the ABP UI family. Work, develop, test, create,
> improve, laugh and curse in different languages. Frontend developers unite!

Done.

https://codereview.adblockplus.org/29522597/diff/29522598/pages/jobs/adblock-...
pages/jobs/adblock-plus-frontend-developer.md:16: 100 million people are looking
for you. Yes! 100 million people, every day, looking for you. If every one of
them wrote ‘Thank you!’ on your profile page you would have a billion new
characters instantly. It would look like a mess sure, but it would feel so good!
On 2017/08/24 13:07:48, Lisa wrote:
> I don't really understand this paragraph, but in any case, I'd at least change
> '100 million' to 'One hundred million' since it's at the beginning of the
> sentence.
> 
> One hundred million people are looking for you. Yes! One hundred million
people,
> every day, looking for YOU.

Done.

https://codereview.adblockplus.org/29522597/diff/29522598/pages/jobs/adblock-...
pages/jobs/adblock-plus-frontend-developer.md:18: That’s basically what we
offer, a chance to be a part of the ABP family; work, develop, test, create,
improve, laugh, laugh in different languages, curse in different languages – all
the good things of being part of a team of capable developers.
On 2017/08/24 13:07:48, Lisa wrote:
> That’s basically what we offer, a chance to be a part of the ABP family. Work,
> develop, test, create, improve, laugh in different languages, curse in
different
> languages – all the good things of being part of a team of capable developers.

Done.

https://codereview.adblockplus.org/29522597/diff/29522598/pages/jobs/adblock-...
pages/jobs/adblock-plus-frontend-developer.md:22: - Writing code for ABP UI
various platforms, handling aspects like: first run page, options page, icon
pop-up, issue reporter, etc.
On 2017/08/24 13:07:48, Lisa wrote:
> Options page

Done.

https://codereview.adblockplus.org/29522597/diff/29522598/pages/jobs/adblock-...
pages/jobs/adblock-plus-frontend-developer.md:25: - Bouncing ideas within the
team, making architectural changes.
On 2017/08/24 13:07:48, Lisa wrote:
> remove the period after 'changes'

Done.

[juliandoucette, 2017-08-24 14:26:55]

LGTM

Yes.