Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(677)

Issue 29523555: Issue 5552 - use strict mode for all JS in libadblocklus (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by sergei
Modified:
2 years, 9 months ago
Reviewers:
anton, hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : move setting of strict mode to do it once #

Total comments: 2

Patch Set 3 : move setting of V8 flags at the very beginning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -26 lines) Patch
M lib/compat.js View 1 chunk +1 line, -1 line 0 comments Download
M src/JsEngine.cpp View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M test/FileSystemJsObject.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M test/GlobalJsObject.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M test/JsEngine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M test/WebRequest.cpp View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6
sergei
2 years, 9 months ago (2017-08-22 07:30:22 UTC) #1
anton
https://codereview.adblockplus.org/29523555/diff/29523556/src/JsEngine.cpp File src/JsEngine.cpp (right): https://codereview.adblockplus.org/29523555/diff/29523556/src/JsEngine.cpp#newcode79 src/JsEngine.cpp:79: std::string cmd = "--use_strict"; https://issues.adblockplus.org/ticket/5552#comment:2
2 years, 9 months ago (2017-08-22 07:37:05 UTC) #2
anton
https://codereview.adblockplus.org/29523555/diff/29523563/src/JsEngine.cpp File src/JsEngine.cpp (right): https://codereview.adblockplus.org/29523555/diff/29523563/src/JsEngine.cpp#newcode54 src/JsEngine.cpp:54: v8::V8::Initialize(); in v8_initiliazer.cc in chromium `v8::V8::Initialize();` is invoked after ...
2 years, 9 months ago (2017-08-22 08:22:33 UTC) #3
sergei
https://codereview.adblockplus.org/29523555/diff/29523563/src/JsEngine.cpp File src/JsEngine.cpp (right): https://codereview.adblockplus.org/29523555/diff/29523563/src/JsEngine.cpp#newcode54 src/JsEngine.cpp:54: v8::V8::Initialize(); On 2017/08/22 08:22:33, anton wrote: > in v8_initiliazer.cc ...
2 years, 9 months ago (2017-08-22 10:52:19 UTC) #4
anton
On 2017/08/22 10:52:19, sergei wrote: > https://codereview.adblockplus.org/29523555/diff/29523563/src/JsEngine.cpp > File src/JsEngine.cpp (right): > > https://codereview.adblockplus.org/29523555/diff/29523563/src/JsEngine.cpp#newcode54 > ...
2 years, 9 months ago (2017-08-22 10:55:02 UTC) #5
hub
2 years, 9 months ago (2017-08-22 13:04:38 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5