Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29523574: Issue 5522 - ABP.org: Fix ABP install button so that it doesn't cover body text which runs long and… (Closed)

Created:
Aug. 22, 2017, 9:40 a.m. by ire
Modified:
Aug. 31, 2017, 8:48 a.m.
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Issue 5522 - ABP.org: Fix ABP install button so that it doesn't cover body text which runs long and into a new line.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M static/css/index-desktop.css View 3 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 8
ire
Aug. 22, 2017, 9:40 a.m. (2017-08-22 09:40:14 UTC) #1
ire
The video and the text on the side are no longer aligned, but the issue ...
Aug. 22, 2017, 9:41 a.m. (2017-08-22 09:41:53 UTC) #2
juliandoucette
LGTM @Robert will you please test this change before we push it?
Aug. 22, 2017, 9:53 a.m. (2017-08-22 09:53:44 UTC) #3
Robert Raceanu
On 2017/08/22 09:53:44, juliandoucette wrote: > LGTM > > @Robert will you please test this ...
Aug. 22, 2017, 9:58 a.m. (2017-08-22 09:58:34 UTC) #4
juliandoucette
Any update Robert? Judith wanted this by last week (I forgot to tell you).
Aug. 30, 2017, 10:22 a.m. (2017-08-30 10:22:18 UTC) #5
Robert Raceanu
On 2017/08/30 10:22:18, juliandoucette wrote: > Any update Robert? Judith wanted this by last week ...
Aug. 30, 2017, 11:27 a.m. (2017-08-30 11:27:24 UTC) #6
Robert Raceanu
On 2017/08/30 11:27:24, Robert Raceanu wrote: > On 2017/08/30 10:22:18, juliandoucette wrote: > > Any ...
Aug. 31, 2017, 2:46 a.m. (2017-08-31 02:46:45 UTC) #7
ire
Aug. 31, 2017, 8:48 a.m. (2017-08-31 08:48:45 UTC) #8
Message was sent while issue was closed.
On 2017/08/31 02:46:45, Robert Raceanu wrote:
> On 2017/08/30 11:27:24, Robert Raceanu wrote:
> > On 2017/08/30 10:22:18, juliandoucette wrote:
> > > Any update Robert? Judith wanted this by last week (I forgot to tell you).
> > 
> > Sorry, had flattr release, wasn't sure how urgent this was, will test it
today
> > and have results by tmr tops.
> 
> LGTM

Thanks Robert

Powered by Google App Engine
This is Rietveld