Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29523625: Issue 5553 - Updating buildtools dependency to hg:9c8d2c9e4344 (Closed)

Created:
Aug. 22, 2017, 11:02 a.m. by tlucas
Modified:
Aug. 22, 2017, 11:20 a.m.
Visibility:
Public.

Description

Issue 5553 - Updating buildtools dependency to hg:9c8d2c9e4344

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M dependencies View 1 chunk +1 line, -1 line 0 comments Download
M ensure_dependencies.py View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 3
tlucas
Patch Set 1 Updating buildtools dependency to hg:9c8d2c9e4344 Updating ensure_dependencies.py to current version from buildtools ...
Aug. 22, 2017, 11:05 a.m. (2017-08-22 11:05:09 UTC) #1
Sebastian Noack
LGTM
Aug. 22, 2017, 11:11 a.m. (2017-08-22 11:11:13 UTC) #2
Wladimir Palant
Aug. 22, 2017, 11:15 a.m. (2017-08-22 11:15:02 UTC) #3
LGTM

Hints for testers in https://issues.adblockplus.org/ticket/5553 are probably too
technical however. What they really need to know is which bugs should be
retested (#5477 and #4096 it seems) and that the other ones shouldn't have any
impact on the build.

Powered by Google App Engine
This is Rietveld