Delta Between Two Patch Sets: options.html
Issue 29523647:
Issue 5555 - [webextensions] Add a message for Firefox users on the options page (Closed)
Base URL: https://hg.adblockplus.org/adblockpluschrome
Left Patch Set:
Created Aug. 22, 2017, 12:02 p.m.
Right Patch Set: Adjusted message again
Created Aug. 23, 2017, 1:30 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
options.js » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 | 2 |
| 3 <!-- | 3 <!-- |
| 4 - This file is part of Adblock Plus <https://adblockplus.org/>, | 4 - This file is part of Adblock Plus <https://adblockplus.org/>, |
| 5 - Copyright (C) 2006-present eyeo GmbH | 5 - Copyright (C) 2006-present eyeo GmbH |
| 6 - | 6 - |
| 7 - Adblock Plus is free software: you can redistribute it and/or modify | 7 - Adblock Plus is free software: you can redistribute it and/or modify |
| 8 - it under the terms of the GNU General Public License version 3 as | 8 - it under the terms of the GNU General Public License version 3 as |
| 9 - published by the Free Software Foundation. | 9 - published by the Free Software Foundation. |
| 10 - | 10 - |
| (...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 48 margin-top: 0.5em; | 48 margin-top: 0.5em; |
| 49 } | 49 } |
| 50 | 50 |
| 51 button | 51 button |
| 52 { | 52 { |
| 53 white-space: pre; | 53 white-space: pre; |
| 54 } | 54 } |
| 55 | 55 |
| 56 #firefox-warning | 56 #firefox-warning |
| 57 { | 57 { |
| 58 font-size: 120%; | 58 margin-bottom: 20px; |
|
Thomas Greiner
2017/08/22 17:13:25
Coding style: "CSS rule declaration order should f
Wladimir Palant
2017/08/22 18:44:06
Not very specific but I tried my best...
| |
| 59 padding: 10px; | |
| 59 border: 1px solid #cccccc; | 60 border: 1px solid #cccccc; |
| 60 border-radius: 3px; | 61 border-radius: 3px; |
| 61 background-color: #ffcccc; | 62 background-color: #ffcccc; |
| 62 margin-bottom: 20px; | 63 font-size: 120%; |
| 63 padding: 10px; | |
| 64 } | 64 } |
| 65 | 65 |
| 66 #subscriptionTemplate, | 66 #subscriptionTemplate, |
| 67 #addSubscriptionContainer, | 67 #addSubscriptionContainer, |
| 68 #customSubscriptionContainer | 68 #customSubscriptionContainer |
| 69 { | 69 { |
| 70 display: none; | 70 display: none; |
| 71 } | 71 } |
| 72 | 72 |
| 73 #acceptableAdsContainer | 73 #acceptableAdsContainer |
| (...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 149 <img src="icons/detailed/abp-32.png" srcset="icons/detailed/abp-64.png 2x" > | 149 <img src="icons/detailed/abp-32.png" srcset="icons/detailed/abp-64.png 2x" > |
| 150 </td> | 150 </td> |
| 151 <td> | 151 <td> |
| 152 <h1><span class="i18n_options"></span></h1> | 152 <h1><span class="i18n_options"></span></h1> |
| 153 </td> | 153 </td> |
| 154 </tr> | 154 </tr> |
| 155 </table> | 155 </table> |
| 156 | 156 |
| 157 <div id="firefox-warning" hidden> | 157 <div id="firefox-warning" hidden> |
| 158 Don't like what you see? | 158 Don't like what you see? |
| 159 <a href="https://adblockplus.org/blog/the-plan-towards-offering-adblock-plus- for-firefox-as-a-web-extension">We neither</a>. | 159 <a href="https://adblockplus.org/blog/the-plan-towards-offering-adblock-plus- for-firefox-as-a-web-extension" target="_blank">Neither do we</a>. |
|
Thomas Greiner
2017/08/22 17:13:25
I assume that we decided against using documentati
Thomas Greiner
2017/08/22 17:13:25
Detail: All existing external links open in a sepa
Wladimir Palant
2017/08/22 18:44:06
Yes, this is a temporary thing.
On 2017/08/22 17:
| |
| 160 We will improve this page soon. | 160 This page will be improved soon. |
|
Thomas Greiner
2017/08/22 17:13:25
It's understandable that this doesn't need to be t
Wladimir Palant
2017/08/22 18:44:06
We simply cannot translate it, by the time we'll h
| |
| 161 </div> | 161 </div> |
| 162 | 162 |
| 163 <div id="tabs"> | 163 <div id="tabs"> |
| 164 <ul> | 164 <ul> |
| 165 <li><a href="#tab-filterlists"><span class="i18n_filter_lists"></span></a></ li> | 165 <li><a href="#tab-filterlists"><span class="i18n_filter_lists"></span></a></ li> |
| 166 <li><a href="#tab-userfilters"><span class="i18n_add_your_own_filters"></spa n></a></li> | 166 <li><a href="#tab-userfilters"><span class="i18n_add_your_own_filters"></spa n></a></li> |
| 167 <li><a href="#tab-whitelisted"><span class="i18n_whitelisted_domains"></span ></a></li> | 167 <li><a href="#tab-whitelisted"><span class="i18n_whitelisted_domains"></span ></a></li> |
| 168 <li><a href="#tab-general"><span class="i18n_general"></span></a></li> | 168 <li><a href="#tab-general"><span class="i18n_general"></span></a></li> |
| 169 </ul> | 169 </ul> |
| 170 | 170 |
| (...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 299 <input type="checkbox" id="shouldShowNotifications" /><label for="should ShowNotifications" class="i18n_overlay_shownotifications_label"></label> | 299 <input type="checkbox" id="shouldShowNotifications" /><label for="should ShowNotifications" class="i18n_overlay_shownotifications_label"></label> |
| 300 </div> | 300 </div> |
| 301 </p> | 301 </p> |
| 302 | 302 |
| 303 <p id="found-a-bug" class="i18n_found_a_bug"></p> | 303 <p id="found-a-bug" class="i18n_found_a_bug"></p> |
| 304 </div> | 304 </div> |
| 305 </div> | 305 </div> |
| 306 | 306 |
| 307 </body> | 307 </body> |
| 308 </html> | 308 </html> |
| LEFT | RIGHT |
« no previous file
|
options.js » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
