Issue 5555 - [webextensions] Add a message for Firefox users on the options page

Issue 5555 - [webextensions] Add a message for Firefox users on the options page

[Sebastian Noack, 2017-08-22 12:08:00]

LGTM. But strictly speaking this code while in adblockpluschrome, is part of the
UI module, which I'm not the module owner of.

[Thomas Greiner, 2017-08-22 17:13:26]

Thanks for looping me in. I mentioned a couple of things we could tackle but the
only essential thing is getting the approval from Lisa to ensure that we
communicate our message properly.

https://codereview.adblockplus.org/29523647/diff/29523648/options.html
File options.html (right):

https://codereview.adblockplus.org/29523647/diff/29523648/options.html#newcode58
options.html:58: font-size: 120%;
Coding style: "CSS rule declaration order should follow the WordPress CSS Coding
Standards"

Here's the property order that it refers to:
- Display
- Positioning
- Box model
- Colors and Typography
- Other

https://codereview.adblockplus.org/29523647/diff/29523648/options.html#newcod...
options.html:159: <a
href="https://adblockplus.org/blog/the-plan-towards-offering-adblock-plus-for-firefox-as-a-web-extension">​We
neither</a>.
Detail: All existing external links open in a separate tab so I'd recommend
doing the same here.

https://codereview.adblockplus.org/29523647/diff/29523648/options.html#newcod...
options.html:159: <a
href="https://adblockplus.org/blog/the-plan-towards-offering-adblock-plus-for-firefox-as-a-web-extension">​We
neither</a>.
I assume that we decided against using documentation links here since we don't
intend to show this message to our stable build users so it doesn't matter
whether the link will break in the future. Is this assumption correct?

https://codereview.adblockplus.org/29523647/diff/29523648/options.html#newcod...
options.html:160: We will improve this page soon.
It's understandable that this doesn't need to be translated because it'll only
be shown to gecko-webext build users but has this text at least been approved by
Lisa?

[Wladimir Palant, 2017-08-22 18:44:07]

https://codereview.adblockplus.org/29523647/diff/29523648/options.html
File options.html (right):

https://codereview.adblockplus.org/29523647/diff/29523648/options.html#newcode58
options.html:58: font-size: 120%;
On 2017/08/22 17:13:25, Thomas Greiner wrote:
> Here's the property order that it refers to:
> - Display
> - Positioning
> - Box model
> - Colors and Typography
> - Other

Not very specific but I tried my best...

https://codereview.adblockplus.org/29523647/diff/29523648/options.html#newcod...
options.html:159: <a
href="https://adblockplus.org/blog/the-plan-towards-offering-adblock-plus-for-firefox-as-a-web-extension">​We
neither</a>.
On 2017/08/22 17:13:25, Thomas Greiner wrote:
> I assume that we decided against using documentation links here since we don't
> intend to show this message to our stable build users so it doesn't matter
> whether the link will break in the future. Is this assumption correct?

Yes, this is a temporary thing.

On 2017/08/22 17:13:25, Thomas Greiner wrote:
> Detail: All existing external links open in a separate tab so I'd recommend
> doing the same here.

Done.

https://codereview.adblockplus.org/29523647/diff/29523648/options.html#newcod...
options.html:160: We will improve this page soon.
On 2017/08/22 17:13:25, Thomas Greiner wrote:
> It's understandable that this doesn't need to be translated because it'll only
> be shown to gecko-webext build users

We simply cannot translate it, by the time we'll have translations there will be
no point having this message.

> but has this text at least been approved by Lisa?

I'll check with her.

[hub, 2017-08-23 12:45:53]

https://codereview.adblockplus.org/29523647/diff/29523743/options.html
File options.html (right):

https://codereview.adblockplus.org/29523647/diff/29523743/options.html#newcod...
options.html:159: <a
href="https://adblockplus.org/blog/the-plan-towards-offering-adblock-plus-for-firefox-as-a-web-extension"
target="_blank">​We neither</a>.
Lisa wrote "Neither do we." 

https://issues.adblockplus.org/ticket/5555#comment:6

[Wladimir Palant, 2017-08-23 13:30:46]

https://codereview.adblockplus.org/29523647/diff/29523743/options.html
File options.html (right):

https://codereview.adblockplus.org/29523647/diff/29523743/options.html#newcod...
options.html:159: <a
href="https://adblockplus.org/blog/the-plan-towards-offering-adblock-plus-for-firefox-as-a-web-extension"
target="_blank">​We neither</a>.
On 2017/08/23 12:45:52, hub wrote:
> Lisa wrote "Neither do we." 
> 
> https://issues.adblockplus.org/ticket/5555#comment:6

Right, fixed that.

[saroyanm, 2017-08-23 14:56:42]

LGTM