Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java

Issue 29524565: Issue 5556 - remove LogSystem setters (Closed) Base URL: github.com:abby-sergz/libadblockplus-android.git
Left Patch Set: Created Aug. 23, 2017, 11:49 a.m.
Right Patch Set: address comments Created Aug. 24, 2017, 1:38 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 19 matching lines...) Expand all
30 registerNatives(); 30 registerNatives();
31 } 31 }
32 32
33 public JsEngine(final AppInfo appInfo, final LogSystem logSystem) 33 public JsEngine(final AppInfo appInfo, final LogSystem logSystem)
34 { 34 {
35 this(ctor(appInfo, logSystem != null ? logSystem.ptr : 0)); 35 this(ctor(appInfo, logSystem != null ? logSystem.ptr : 0));
36 } 36 }
37 37
38 public JsEngine(final AppInfo appInfo) 38 public JsEngine(final AppInfo appInfo)
39 { 39 {
40 this(appInfo, /* logSystem */null); 40 this(appInfo, null);
anton 2017/08/24 11:12:50 please remove comment
sergei 2017/08/24 13:39:10 Done.
41 } 41 }
42 42
43 protected JsEngine(final long ptr) 43 protected JsEngine(final long ptr)
44 { 44 {
45 this.ptr = ptr; 45 this.ptr = ptr;
46 this.disposer = new Disposer(this, new DisposeWrapper(ptr)); 46 this.disposer = new Disposer(this, new DisposeWrapper(ptr));
47 } 47 }
48 48
49 public void setEventCallback(final String eventName, final EventCallback callb ack) 49 public void setEventCallback(final String eventName, final EventCallback callb ack)
50 { 50 {
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 private final static native void setWebRequest(long ptr, long webRequestPtr); 147 private final static native void setWebRequest(long ptr, long webRequestPtr);
148 148
149 private final static native JsValue newValue(long ptr, long value); 149 private final static native JsValue newValue(long ptr, long value);
150 150
151 private final static native JsValue newValue(long ptr, boolean value); 151 private final static native JsValue newValue(long ptr, boolean value);
152 152
153 private final static native JsValue newValue(long ptr, String value); 153 private final static native JsValue newValue(long ptr, String value);
154 154
155 private final static native void dtor(long ptr); 155 private final static native void dtor(long ptr);
156 } 156 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld