Issue 5556 - remove LogSystem setters

COLLABORATOR=anton@adblockplus.org

[anton, 2017-08-24 11:07:46]

On 2017/08/23 11:51:09, sergei wrote:

Please add it depends on https://codereview.adblockplus.org/29523679/ and
https://codereview.adblockplus.org/29523682/

[sergei, 2017-08-24 11:09:23]

On 2017/08/24 11:07:46, anton wrote:
> On 2017/08/23 11:51:09, sergei wrote:
> 
> Please add it depends on https://codereview.adblockplus.org/29523679/ and
> https://codereview.adblockplus.org/29523682/

done

[anton, 2017-08-24 11:12:50]

https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
File
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java
(right):

https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java:45:
return null;
comment like "returning null log system make JsEngine using default log system
impl" is needed

https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
File libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java
(right):

https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java:40:
this(appInfo, /* logSystem */null);
please remove comment

[anton, 2017-08-24 11:23:45]

https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
File
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java
(left):

https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java:38:
jsEngine.setDefaultLogSystem();
as far as i can see passing `null` as log system makes not invoking
'setLogSystem' in JniJsEngine.cpp and it's not equal to using DefaultLogSystem
as it was previously. Can you confirm no log system is used at all?

[sergei, 2017-08-24 11:38:26]

https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
File
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java
(left):

https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java:38:
jsEngine.setDefaultLogSystem();
On 2017/08/24 11:23:44, anton wrote:
> as far as i can see passing `null` as log system makes not invoking
> 'setLogSystem' in JniJsEngine.cpp and it's not equal to using DefaultLogSystem
> as it was previously. Can you confirm no log system is used at all?

Right now default log system is created by JsEngine when JsEngine is being
created. In recent version of libadblockplus if log system is nullptr then it's
created when Platform is being created. So, in both cases a default log system
is used and in newer libadblockplus it's impossible to not use any log system.

[anton, 2017-08-24 11:39:28]

On 2017/08/24 11:38:26, sergei wrote:
>
https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
> File
>
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java
> (left):
> 
>
https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
>
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java:38:
> jsEngine.setDefaultLogSystem();
> On 2017/08/24 11:23:44, anton wrote:
> > as far as i can see passing `null` as log system makes not invoking
> > 'setLogSystem' in JniJsEngine.cpp and it's not equal to using
DefaultLogSystem
> > as it was previously. Can you confirm no log system is used at all?
> 
> Right now default log system is created by JsEngine when JsEngine is being
> created. In recent version of libadblockplus if log system is nullptr then
it's
> created when Platform is being created. So, in both cases a default log system
> is used and in newer libadblockplus it's impossible to not use any log system.

That's clear

[sergei, 2017-08-24 13:39:10]

https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
File
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java
(right):

https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java:45:
return null;
On 2017/08/24 11:12:50, anton wrote:
> comment like "returning null log system make JsEngine using default log system
> impl" is needed

Done.

https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
File libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java
(right):

https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java:40:
this(appInfo, /* logSystem */null);
On 2017/08/24 11:12:50, anton wrote:
> please remove comment

Done.

[anton, 2017-08-24 14:02:42]

On 2017/08/24 13:39:10, sergei wrote:
>
https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
> File
>
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java
> (right):
> 
>
https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
>
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java:45:
> return null;
> On 2017/08/24 11:12:50, anton wrote:
> > comment like "returning null log system make JsEngine using default log
system
> > impl" is needed
> 
> Done.
> 
>
https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
> File libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java
> (right):
> 
>
https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
> libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java:40:
> this(appInfo, /* logSystem */null);
> On 2017/08/24 11:12:50, anton wrote:
> > please remove comment
> 
> Done.

LGTM

[diegocarloslima, 2017-08-28 21:09:46]

On 2017/08/24 14:02:42, anton wrote:
> On 2017/08/24 13:39:10, sergei wrote:
> >
>
https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
> > File
> >
>
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java
> > (right):
> > 
> >
>
https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
> >
>
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java:45:
> > return null;
> > On 2017/08/24 11:12:50, anton wrote:
> > > comment like "returning null log system make JsEngine using default log
> system
> > > impl" is needed
> > 
> > Done.
> > 
> >
>
https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
> > File libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java
> > (right):
> > 
> >
>
https://codereview.adblockplus.org/29524565/diff/29524574/libadblockplus-andr...
> > libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java:40:
> > this(appInfo, /* logSystem */null);
> > On 2017/08/24 11:12:50, anton wrote:
> > > please remove comment
> > 
> > Done.
> 
> LGTM

LGTM