Unified Diff: libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java
Issue 29524565:
Issue 5556 - remove LogSystem setters (Closed)
Base URL: github.com:abby-sergz/libadblockplus-android.git
Patch Set:
Created Aug. 23, 2017, 11:49 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java ('K')
|
« libadblockplus-android/jni/JniJsEngine.cpp ('k')
|
libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java |
| diff --git a/libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java b/libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java |
| index e2f9c091fce60d7d64c25d60c517c26657bca8ae..d841e0a39d3366687dd7b92f9d6fa0da0a7a16fc 100644 |
| --- a/libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java |
| +++ b/libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java |
| @@ -30,9 +30,14 @@ public final class JsEngine implements Disposable |
| registerNatives(); |
| } |
| + public JsEngine(final AppInfo appInfo, final LogSystem logSystem) |
| + { |
| + this(ctor(appInfo, logSystem != null ? logSystem.ptr : 0)); |
| + } |
| + |
| public JsEngine(final AppInfo appInfo) |
| { |
| - this(ctor(appInfo)); |
| + this(appInfo, /* logSystem */null); |
|
anton
2017/08/24 11:12:50
please remove comment
sergei
2017/08/24 13:39:10
Done.
|
| } |
| protected JsEngine(final long ptr) |
| @@ -83,16 +88,6 @@ public final class JsEngine implements Disposable |
| setDefaultFileSystem(this.ptr, basePath); |
| } |
| - public void setDefaultLogSystem() |
| - { |
| - setDefaultLogSystem(this.ptr); |
| - } |
| - |
| - public void setLogSystem(final LogSystem logSystem) |
| - { |
| - setLogSystem(this.ptr, logSystem.ptr); |
| - } |
| - |
| public void setWebRequest(final WebRequest webRequest) |
| { |
| setWebRequest(this.ptr, webRequest.ptr); |
| @@ -137,7 +132,7 @@ public final class JsEngine implements Disposable |
| private final static native void registerNatives(); |
| - private final static native long ctor(AppInfo appInfo); |
| + private final static native long ctor(AppInfo appInfo, long logSystemPtr); |
| private final static native void setEventCallback(long ptr, String eventName, long callback); |
| @@ -149,10 +144,6 @@ public final class JsEngine implements Disposable |
| private final static native void setDefaultFileSystem(long ptr, String basePath); |
| - private final static native void setLogSystem(long ptr, long logSystemPtr); |
| - |
| - private final static native void setDefaultLogSystem(long ptr); |
| - |
| private final static native void setWebRequest(long ptr, long webRequestPtr); |
| private final static native JsValue newValue(long ptr, long value); |
« libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java ('K')
|
« libadblockplus-android/jni/JniJsEngine.cpp ('k')
|
libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java » ('j')
|
no next file with comments »
