libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java - Issue 29524565: Issue 5556 - remove LogSystem setters

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java

Issue 29524565: Issue 5556 - remove LogSystem setters (Closed) Base URL: github.com:abby-sergz/libadblockplus-android.git

Patch Set: address comments Created Aug. 24, 2017, 1:38 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java

diff --git a/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java b/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java

index 8bdebb9c6de033e05ff69ddac0953e5243b2ce92..9dbd9c358060125a4d9490fc9b9da42ce6cdf6be 100644

--- a/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java

+++ b/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java

@@ -253,14 +253,12 @@ public final class AdblockEngine

private void createEngines()

{

- engine.jsEngine = new JsEngine(appInfo);

+ engine.logSystem = new AndroidLogSystem();

+ engine.jsEngine = new JsEngine(appInfo, engine.logSystem);

engine.jsEngine.setDefaultFileSystem(basePath);

engine.jsEngine.setWebRequest(engine.webRequest);

- engine.logSystem = new AndroidLogSystem();

- engine.jsEngine.setLogSystem(engine.logSystem);

engine.filterEngine = new FilterEngine(engine.jsEngine, isAllowedConnectionCallback);

}

« no previous file with comments | « libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java ('k') | no next file » | no next file with comments »