Issue 5506 - Fix notification test

Issue 5506 - Fix notification test

[hub, 2017-08-23 17:00:04]

This just fix the build and mark the test as disabled.

[sergei, 2017-08-23 18:00:13]

I know that the change is only to compile it but I think a couple of mentioned
changes could be done here as well.

https://codereview.adblockplus.org/29525558/diff/29525559/test/Notification.cpp
File test/Notification.cpp (right):

https://codereview.adblockplus.org/29525558/diff/29525559/test/Notification.c...
test/Notification.cpp:24: //#define NotificationMockWebRequestTest_ENABLED
Could you please also remove this define and move the comment next to the test
body.

https://codereview.adblockplus.org/29525558/diff/29525559/test/Notification.c...
test/Notification.cpp:93: BaseJsTest::SetUp();
Since platform is created below could you please remove this call.

[hub, 2017-08-23 19:21:56]

updated patch

https://codereview.adblockplus.org/29525558/diff/29525559/test/Notification.cpp
File test/Notification.cpp (right):

https://codereview.adblockplus.org/29525558/diff/29525559/test/Notification.c...
test/Notification.cpp:24: //#define NotificationMockWebRequestTest_ENABLED
On 2017/08/23 18:00:12, sergei wrote:
> Could you please also remove this define and move the comment next to the test
> body.

Done.

https://codereview.adblockplus.org/29525558/diff/29525559/test/Notification.c...
test/Notification.cpp:93: BaseJsTest::SetUp();
On 2017/08/23 18:00:12, sergei wrote:
> Since platform is created below could you please remove this call.

Done.

[sergei, 2017-08-23 19:27:23]

https://codereview.adblockplus.org/29525558/diff/29525629/test/Notification.cpp
File test/Notification.cpp (left):

https://codereview.adblockplus.org/29525558/diff/29525629/test/Notification.c...
test/Notification.cpp:23: // one need to set INITIAL_DELAY to about 2000 msec in
notification.js.
What about moving of the comment, it's essential to run the test.

[hub, 2017-08-23 19:54:05]

https://codereview.adblockplus.org/29525558/diff/29525629/test/Notification.cpp
File test/Notification.cpp (left):

https://codereview.adblockplus.org/29525558/diff/29525629/test/Notification.c...
test/Notification.cpp:23: // one need to set INITIAL_DELAY to about 2000 msec in
notification.js.
On 2017/08/23 19:27:22, sergei wrote:
> What about moving of the comment, it's essential to run the test.

Oops. Done.

[sergei, 2017-08-23 20:34:55]

LGTM