Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(381)

Issue 29526591: Issue 5562 - Move Edge storage to IndexedDB (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 6 months ago by Oleksandr
Modified:
2 years, 6 months ago
Reviewers:
kzar, Sebastian Noack
Visibility:
Public.

Description

This is intended to be published under the edge bookmark.

Patch Set 1 #

Total comments: 15

Patch Set 2 : Remove migration from localStorage logic #

Patch Set 3 : Improve list loading logic and remove redundant checks #

Total comments: 2

Patch Set 4 : Remove accidental code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -28 lines) Patch
M lib/io.js View 1 2 3 2 chunks +9 lines, -28 lines 0 comments Download
A lib/localforage.min.js View 1 chunk +7 lines, -0 lines 0 comments Download
M metadata.edge View 3 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8
Oleksandr
https://codereview.adblockplus.org/29526591/diff/29526592/metadata.edge File metadata.edge (right): https://codereview.adblockplus.org/29526591/diff/29526592/metadata.edge#newcode12 metadata.edge:12: backgroundScripts = lib/localforage.min.js We need to include localforage first, ...
2 years, 6 months ago (2017-08-24 11:48:46 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29526591/diff/29526592/lib/io.js File lib/io.js (right): https://codereview.adblockplus.org/29526591/diff/29526592/lib/io.js#newcode33 lib/io.js:33: // Make sure we do not have subscriptions in ...
2 years, 6 months ago (2017-08-24 12:11:47 UTC) #2
Oleksandr
https://codereview.adblockplus.org/29526591/diff/29526592/lib/io.js File lib/io.js (right): https://codereview.adblockplus.org/29526591/diff/29526592/lib/io.js#newcode33 lib/io.js:33: // Make sure we do not have subscriptions in ...
2 years, 6 months ago (2017-08-24 14:43:59 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29526591/diff/29526592/lib/io.js File lib/io.js (right): https://codereview.adblockplus.org/29526591/diff/29526592/lib/io.js#newcode53 lib/io.js:53: if (err || !value) On 2017/08/24 14:43:58, Oleksandr wrote: ...
2 years, 6 months ago (2017-08-24 14:56:27 UTC) #4
Oleksandr
https://codereview.adblockplus.org/29526591/diff/29526592/lib/io.js File lib/io.js (right): https://codereview.adblockplus.org/29526591/diff/29526592/lib/io.js#newcode53 lib/io.js:53: if (err || !value) On 2017/08/24 14:56:27, Sebastian Noack ...
2 years, 6 months ago (2017-08-24 16:53:29 UTC) #5
Sebastian Noack
https://codereview.adblockplus.org/29526591/diff/29526666/lib/io.js File lib/io.js (right): https://codereview.adblockplus.org/29526591/diff/29526666/lib/io.js#newcode31 lib/io.js:31: console.trace(); Did you forget to remove this?
2 years, 6 months ago (2017-08-24 17:11:01 UTC) #6
Oleksandr
https://codereview.adblockplus.org/29526591/diff/29526666/lib/io.js File lib/io.js (right): https://codereview.adblockplus.org/29526591/diff/29526666/lib/io.js#newcode31 lib/io.js:31: console.trace(); On 2017/08/24 17:11:00, Sebastian Noack wrote: > Did ...
2 years, 6 months ago (2017-08-24 17:17:04 UTC) #7
Sebastian Noack
2 years, 6 months ago (2017-08-24 17:24:25 UTC) #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5