Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29526599: Noissue - Fix download link for new Adblock Plus for Firefox builds (Closed)

Created:
Aug. 24, 2017, 12:17 p.m. by Wladimir Palant
Modified:
Aug. 24, 2017, 12:57 p.m.
Reviewers:
Sebastian Noack
CC:
tlucas
Base URL:
https://hg.adblockplus.org/sitescripts/
Visibility:
Public.

Description

Noissue - Fix download link for new Adblock Plus for Firefox builds

Patch Set 1 #

Patch Set 2 : Fix it properly this time #

Total comments: 2

Patch Set 3 : Use list literals #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sitescripts/extensions/template/nightlies.html View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
Wladimir Palant
Aug. 24, 2017, 12:17 p.m. (2017-08-24 12:17:07 UTC) #1
Sebastian Noack
LGTM.
Aug. 24, 2017, 12:19 p.m. (2017-08-24 12:19:48 UTC) #2
Wladimir Palant
So much for not testing changes - this was a syntax error in Jinja. Please ...
Aug. 24, 2017, 12:27 p.m. (2017-08-24 12:27:16 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29526599/diff/29526602/sitescripts/extensions/template/nightlies.html File sitescripts/extensions/template/nightlies.html (right): https://codereview.adblockplus.org/29526599/diff/29526602/sitescripts/extensions/template/nightlies.html#newcode31 sitescripts/extensions/template/nightlies.html:31: {% if (config.type == 'gecko' or config.type == 'gecko-webext') ...
Aug. 24, 2017, 12:31 p.m. (2017-08-24 12:31:08 UTC) #4
Wladimir Palant
https://codereview.adblockplus.org/29526599/diff/29526602/sitescripts/extensions/template/nightlies.html File sitescripts/extensions/template/nightlies.html (right): https://codereview.adblockplus.org/29526599/diff/29526602/sitescripts/extensions/template/nightlies.html#newcode31 sitescripts/extensions/template/nightlies.html:31: {% if (config.type == 'gecko' or config.type == 'gecko-webext') ...
Aug. 24, 2017, 12:43 p.m. (2017-08-24 12:43:09 UTC) #5
Sebastian Noack
Aug. 24, 2017, 12:56 p.m. (2017-08-24 12:56:27 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld