Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29526696: Issue 5556 - remove WebRequest setter (Closed)

Created:
Aug. 24, 2017, 5:24 p.m. by sergei
Modified:
Aug. 29, 2017, 10:46 a.m.
Reviewers:
diegocarloslima, anton, jens
CC:
Felix Dahlke, René Jeschke
Base URL:
github.com:abby-sergz/libadblockplus-android.git
Visibility:
Public.

Description

# depends on https://codereview.adblockplus.org/29524565/ COLLABORATOR=anton@adblockplus.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -54 lines) Patch
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java View 3 chunks +8 lines, -2 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestTest.java View 2 chunks +3 lines, -4 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java View 3 chunks +7 lines, -2 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineGenericTest.java View 2 chunks +7 lines, -3 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java View 2 chunks +7 lines, -3 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/MockWebRequestTest.java View 1 chunk +2 lines, -4 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/NotificationTest.java View 2 chunks +7 lines, -2 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UpdateCheckTest.java View 1 chunk +1 line, -2 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UpdaterTest.java View 1 chunk +1 line, -2 lines 0 comments Download
M libadblockplus-android/jni/JniJsEngine.cpp View 5 chunks +8 lines, -16 lines 0 comments Download
M libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java View 4 chunks +9 lines, -11 lines 0 comments Download
M libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6
sergei
Aug. 24, 2017, 5:25 p.m. (2017-08-24 17:25:50 UTC) #1
anton
On 2017/08/24 17:25:50, sergei wrote: LGTM
Aug. 25, 2017, 7:22 a.m. (2017-08-25 07:22:39 UTC) #2
anton
On 2017/08/25 07:22:39, anton wrote: > On 2017/08/24 17:25:50, sergei wrote: > > LGTM The ...
Aug. 25, 2017, 7:23 a.m. (2017-08-25 07:23:24 UTC) #3
sergei
On 2017/08/25 07:23:24, anton wrote: > The only idea is to use Builder design pattern ...
Aug. 25, 2017, 7:33 a.m. (2017-08-25 07:33:04 UTC) #4
anton
On 2017/08/25 07:33:04, sergei wrote: > On 2017/08/25 07:23:24, anton wrote: > > The only ...
Aug. 25, 2017, 7:33 a.m. (2017-08-25 07:33:49 UTC) #5
diegocarloslima
Aug. 28, 2017, 8:44 p.m. (2017-08-28 20:44:59 UTC) #6 
On 2017/08/25 07:33:49, anton wrote:
> On 2017/08/25 07:33:04, sergei wrote:
> > On 2017/08/25 07:23:24, anton wrote:
> > > The only idea is to use Builder design pattern in the future as JsEngine
> ctor
> > > becomes too heavy.
> > 
> > I don't mind but I would propose to come back to it after updating of
> > libadblockplus.
> 
> agree

LGTM

Powered by Google App Engine
This is Rietveld