libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java - Issue 29526696: Issue 5556 - remove WebRequest setter

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java

Issue 29526696: Issue 5556 - remove WebRequest setter (Closed) Base URL: github.com:abby-sergz/libadblockplus-android.git

Patch Set: Created Aug. 24, 2017, 5:24 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java

diff --git a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java

index 25b70d7055ff3b2804b9ffc021407e709fad534a..b65b178323a9219005bd3e4dd9ba5363755449a0 100644

--- a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java

+++ b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java

@@ -22,6 +22,7 @@ import android.os.SystemClock;

import org.adblockplus.libadblockplus.HeaderEntry;

import org.adblockplus.libadblockplus.ServerResponse;

import org.adblockplus.libadblockplus.Subscription;

+import org.adblockplus.libadblockplus.WebRequest;

import org.adblockplus.libadblockplus.android.AndroidWebRequest;

import org.adblockplus.libadblockplus.android.AndroidWebRequestResourceWrapper;

import org.adblockplus.libadblockplus.android.Utils;

@@ -105,7 +106,6 @@ public class AndroidWebRequestResourceWrapperTest extends FilterEngineGenericTes

@Override

protected void setUp() throws Exception

{

- super.setUp();

request = new TestRequest();

preloadMap = new HashMap<String, Integer>();

@@ -115,7 +115,13 @@ public class AndroidWebRequestResourceWrapperTest extends FilterEngineGenericTes

wrapperListener = new TestWrapperListener();

wrapper.setListener(wrapperListener);

- jsEngine.setWebRequest(wrapper);

+ super.setUp();

+ }

+ @Override

+ protected WebRequest createWebRequest()

+ {

+ return wrapper;

}

private void updateSubscriptions()

« no previous file with comments | « no previous file | libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestTest.java » ('j') | no next file with comments »