libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java - Issue 29526696: Issue 5556 - remove WebRequest setter

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java

Issue 29526696: Issue 5556 - remove WebRequest setter (Closed) Base URL: github.com:abby-sergz/libadblockplus-android.git

Patch Set: Created Aug. 24, 2017, 5:24 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineGenericTest.java ('k') | libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/MockWebRequestTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java

diff --git a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java

index a85c84e3ae85ebdd65f1cd62d63732eae99ada26..5c57f7646774cb994bf20564d1eb7b82bcfabb7c 100644

--- a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java

+++ b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java

@@ -24,6 +24,7 @@ import org.adblockplus.libadblockplus.HeaderEntry;

import org.adblockplus.libadblockplus.IsAllowedConnectionCallback;

import org.adblockplus.libadblockplus.ServerResponse;

import org.adblockplus.libadblockplus.Subscription;

+import org.adblockplus.libadblockplus.WebRequest;

import org.adblockplus.libadblockplus.android.AndroidWebRequest;

import org.junit.Test;

@@ -96,13 +97,16 @@ public class IsAllowedConnectionCallbackTest extends BaseJsTest

{

super.setUp();

- request = new TestRequest();

- jsEngine.setWebRequest(request);

callback = new TestCallback();

filterEngine = new FilterEngine(jsEngine, callback);

}

+ @Override

+ protected WebRequest createWebRequest()

+ {

+ return request = new TestRequest();

+ }

private void updateSubscriptions()

{

for (final Subscription s : this.filterEngine.getListedSubscriptions())