libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java - Issue 29526710: Issue 5556 - make C++ implementation of WebRequest manageable only by JsEngine

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java

Issue 29526710: Issue 5556 - make C++ implementation of WebRequest manageable only by JsEngine (Closed) Base URL: github.com:abby-sergz/libadblockplus-android.git

Patch Set: Created Aug. 24, 2017, 5:26 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « libadblockplus-android/jni/JniWebRequest.cpp ('k') | libadblockplus-android/src/org/adblockplus/libadblockplus/WebRequest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java

diff --git a/libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java b/libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java

index ea7cb1af195879ed34fc43c449fa58bd47e1abab..0ee8ccffc1b3b7e7e4904bc5890771d1143d4048 100644

--- a/libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java

+++ b/libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java

@@ -32,7 +32,7 @@ public final class JsEngine implements Disposable

public JsEngine(final AppInfo appInfo, final LogSystem logSystem, final WebRequest webRequest)

{

- this(ctor(appInfo, logSystem, webRequest != null ? webRequest.ptr : 0));

+ this(ctor(appInfo, logSystem, webRequest));

}

public JsEngine(final AppInfo appInfo, final WebRequest webRequest)

@@ -132,7 +132,7 @@ public final class JsEngine implements Disposable

private final static native void registerNatives();

- private final static native long ctor(AppInfo appInfo, LogSystem logSystem, long webRequestPtr);

+ private final static native long ctor(AppInfo appInfo, LogSystem logSystem, WebRequest webRequest);

private final static native void setEventCallback(long ptr, String eventName, long callback);