Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29526710: Issue 5556 - make C++ implementation of WebRequest manageable only by JsEngine (Closed)

Created:
Aug. 24, 2017, 5:26 p.m. by sergei
Modified:
Aug. 29, 2017, 10:53 a.m.
Reviewers:
diegocarloslima, anton, jens
CC:
Felix Dahlke, René Jeschke
Base URL:
github.com:abby-sergz/libadblockplus-android.git
Visibility:
Public.

Description

# depends on https://codereview.adblockplus.org/29526696/ COLLABORATOR=anton@adblockplus.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -97 lines) Patch
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/LazyWebRequest.java View 1 chunk +1 line, -1 line 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/MockWebRequest.java View 1 chunk +1 line, -1 line 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/ThrowingWebRequest.java View 1 chunk +1 line, -1 line 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/MockWebRequestTest.java View 1 chunk +1 line, -1 line 0 comments Download
M libadblockplus-android/jni/JniJsEngine.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M libadblockplus-android/jni/JniWebRequest.cpp View 2 chunks +2 lines, -27 lines 0 comments Download
M libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java View 2 chunks +2 lines, -2 lines 0 comments Download
M libadblockplus-android/src/org/adblockplus/libadblockplus/WebRequest.java View 1 chunk +2 lines, -45 lines 0 comments Download
M libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java View 1 chunk +0 lines, -6 lines 0 comments Download
M libadblockplus-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequest.java View 1 chunk +1 line, -1 line 0 comments Download
M libadblockplus-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequestResourceWrapper.java View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 3
sergei
Aug. 24, 2017, 5:29 p.m. (2017-08-24 17:29:11 UTC) #1
anton
On 2017/08/24 17:29:11, sergei wrote: LGTM
Aug. 25, 2017, 7:23 a.m. (2017-08-25 07:23:42 UTC) #2
diegocarloslima
Aug. 28, 2017, 8:16 p.m. (2017-08-28 20:16:53 UTC) #3
On 2017/08/25 07:23:42, anton wrote:
> On 2017/08/24 17:29:11, sergei wrote:
> 
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld