libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java - Issue 29526710: Issue 5556 - make C++ implementation of WebRequest manageable only by JsEngine

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java

Issue 29526710: Issue 5556 - make C++ implementation of WebRequest manageable only by JsEngine (Closed) Base URL: github.com:abby-sergz/libadblockplus-android.git

Patch Set: Created Aug. 24, 2017, 5:26 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « libadblockplus-android/src/org/adblockplus/libadblockplus/WebRequest.java ('k') | libadblockplus-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java

diff --git a/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java b/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java

index 58adb1822d25be06016938eb5cd3f339cda968a2..8fc07af9d05dc508502bc290a502dc37f299354f 100644

--- a/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java

+++ b/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java

@@ -316,12 +316,6 @@ public final class AdblockEngine

this.showNotificationCallback.dispose();

this.showNotificationCallback = null;

}

- if (this.webRequest != null)

- {

- this.webRequest.dispose();

- this.webRequest = null;

- }

}

public boolean isFirstRun()