Issue 5570 - Make V8 isolate injectable into JsEngine

include/AdblockPlus/Platform.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 32 matching lines @@
   /**
    * A factory to construct DefaultWebRequest.
    */
   WebRequestPtr CreateDefaultWebRequest(const Scheduler& scheduler);
 
   /**
    * A factory to construct LogSystem.
    */
   LogSystemPtr CreateDefaultLogSystem();
 
+  class IV8IsolateProvider;
   class JsEngine;
 
   /**
    * AdblockPlus platform is the main component providing access to other
    * modules.
    *
    * It manages the functionality modules, e.g. JsEngine and FilterEngine as
    * well as allows to correctly work with asynchronous functionality.
    */
   class Platform
@@ skipping 23 matching lines @@
     /**
      * Platform constructor.
      *
      * When a parameter value is nullptr the corresponding default
      * implementation is chosen.
      */
     explicit Platform(CreationParameters&& creationParameters = CreationParameters());
     ~Platform();
 
     /**
-     * Ensures that JsEngine is constructed.
+     * Ensures that JsEngine is constructed. If JsEngine is already present
+     * then the parameters areignored.

[hub, 2017/08/25 13:20:39]

typo: 'are ignored'

[sergei, 2017/08/25 15:02:53]

Done.

      *
-     * @param appInfo Information about the app, if jsEngine is already present
-     *        then the value is ignored.
+     * @param appInfo Information about the app, 
+     * @param isolate A provider of v8::Isolate, if the value is nullptr then
+     *        a default implementation is used.
      */
-    void SetUpJsEngine(const AppInfo& appInfo = AppInfo());
+    void SetUpJsEngine(const AppInfo& appInfo = AppInfo(), std::unique_ptr<IV8IsolateProvider> isolate = nullptr);
 
     /**
      * Retrieves the `JsEngine` instance. It calls SetUpJsEngine if JsEngine is
      * not initialized yet.
      */
     JsEngine& GetJsEngine();
 
     /**
      * Ensures that FilterEngine is constructed. Only the first call is effective.
      *
@@ skipping 38 matching lines @@
     FileSystemPtr fileSystem;
     WebRequestPtr webRequest;
     // used for creation and deletion of modules.
     std::mutex modulesMutex;
     std::shared_ptr<JsEngine> jsEngine;
     std::shared_future<FilterEnginePtr> filterEngine;
   };
 }
 
 #endif // ADBLOCK_PLUS_PLATFORM_H