Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29527588: Issue 5570 - Make V8 isolate injectable into JsEngine (Closed)

Created:
Aug. 25, 2017, 8:27 a.m. by sergei
Modified:
Aug. 28, 2017, 7:37 a.m.
Reviewers:
hub
CC:
Felix Dahlke, anton
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix typo #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -41 lines) Patch
M include/AdblockPlus/JsEngine.h View 1 2 4 chunks +16 lines, -19 lines 0 comments Download
M include/AdblockPlus/Platform.h View 1 2 2 chunks +7 lines, -4 lines 0 comments Download
M src/JsEngine.cpp View 2 chunks +39 lines, -16 lines 0 comments Download
M src/Platform.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
sergei
Aug. 25, 2017, 8:34 a.m. (2017-08-25 08:34:19 UTC) #1
hub
LGTM otherwise https://codereview.adblockplus.org/29527588/diff/29527594/include/AdblockPlus/Platform.h File include/AdblockPlus/Platform.h (right): https://codereview.adblockplus.org/29527588/diff/29527594/include/AdblockPlus/Platform.h#newcode98 include/AdblockPlus/Platform.h:98: * then the parameters areignored. typo: 'are ...
Aug. 25, 2017, 1:20 p.m. (2017-08-25 13:20:39 UTC) #2
sergei
https://codereview.adblockplus.org/29527588/diff/29527594/include/AdblockPlus/Platform.h File include/AdblockPlus/Platform.h (right): https://codereview.adblockplus.org/29527588/diff/29527594/include/AdblockPlus/Platform.h#newcode98 include/AdblockPlus/Platform.h:98: * then the parameters areignored. On 2017/08/25 13:20:39, hub ...
Aug. 25, 2017, 3:02 p.m. (2017-08-25 15:02:53 UTC) #3
hub
Aug. 25, 2017, 4:11 p.m. (2017-08-25 16:11:49 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld